Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-111201: Speed up paste mode in the REPL#119341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 4 commits intopython:mainfrompablogsal:speed
May 22, 2024
Merged

Conversation

pablogsal
Copy link
Member

@pablogsalpablogsal commentedMay 21, 2024•
edited by bedevere-appbot
Loading

@bedevere-appbedevere-appbot mentioned this pull requestMay 21, 2024
7 tasks
@pablogsal
Copy link
MemberAuthor

This depends on#119318 landing first

@pablogsalpablogsal added the topic-replRelated to the interactive shell labelMay 21, 2024
@ambvambv merged commite6572e8 intopython:mainMay 22, 2024
@lysnikolaou
Copy link
Member

lysnikolaou commentedMay 22, 2024•
edited
Loading

I think that this has broken paste. Pasting code shows the last character of the pasted line only. The whole buffer is shown after hitting backspace. If arrows are used between the paste and the backspace, the buffer gets completely messed up.

cc@ambv@pablogsal

@pablogsal
Copy link
MemberAuthor

Hummm, we live tested this several times. I wonder if there is some weird interaction with other PRs we landed

@pablogsal
Copy link
MemberAuthor

We should revert meanwhile I think

@pablogsal
Copy link
MemberAuthor

@lysnikolaou@ambv WDYT?

@lysnikolaou
Copy link
Member

+1 for reverting, otherwise it might be hard to do manual testing of PRs at the sprints.

@lysnikolaou
Copy link
Member

lysnikolaou commentedMay 22, 2024•
edited
Loading

#119432 fixes this.

lysnikolaou pushed a commit to miss-islington/cpython that referenced this pull requestMay 23, 2024
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
lysnikolaou added a commit that referenced this pull requestMay 23, 2024
… (#119439)(cherry picked from commite6572e8)Also includes:*gh-111201: Use calc_complete_screen after bracketed paste in PyREPL (GH-119432)(cherry picked from commit14b063c)Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@pablogsalpablogsal deleted the speed branchMay 23, 2024 12:18
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

Assignees
No one assigned
Labels
skip newstopic-replRelated to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@pablogsal@lysnikolaou@ambv
[8]ページ先頭
©2009-2025 Movatter.jp