Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-119102: Fix REPL for dumb terminal#119332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 2 commits intopython:mainfromvstinner:pyrepl_dumb2
May 21, 2024
Merged

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedMay 21, 2024•
edited by bedevere-appbot
Loading

The site module gets themain module to get _pyrepl.main.

The site module gets the __main__ module to get _pyrepl.__main__.
@lysnikolaoulysnikolaou added skip news topic-replRelated to the interactive shell labelsMay 21, 2024
Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@eugenetriguba
Copy link
Contributor

eugenetriguba commentedMay 21, 2024•
edited
Loading

@vstinner I took a crack at it here when I noticed the first PR that had the mypy fix reverted the bug fix:#119328. Do you have a preference of approach? Happy to close that one out or try to get that test properly working in that PR and just try to get that merged in instead 🙂

Copy link
Contributor

@danielhollasdanielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Works for me!

@vstinnervstinnerenabled auto-merge (squash)May 21, 2024 18:55
@vstinner
Copy link
MemberAuthor

Thanks for the review and testing!

@vstinnervstinner merged commitde8f530 intopython:mainMay 21, 2024
@vstinnervstinner deleted the pyrepl_dumb2 branchMay 21, 2024 20:33
@miss-islington-app
Copy link

Thanks@vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 21, 2024
The site module gets the __main__ module to get _pyrepl.__main__.(cherry picked from commitde8f530)Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

GH-119359 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 21, 2024
lysnikolaou pushed a commit that referenced this pull requestMay 22, 2024
The site module gets the __main__ module to get _pyrepl.__main__.(cherry picked from commitde8f530)Co-authored-by: Victor Stinner <vstinner@python.org>
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
The site module gets the __main__ module to get _pyrepl.__main__.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@danielhollasdanielhollasdanielhollas approved these changes

@lysnikolaoulysnikolaoulysnikolaou approved these changes

Assignees
No one assigned
Labels
skip newstopic-replRelated to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@vstinner@eugenetriguba@danielhollas@lysnikolaou
[8]ページ先頭
©2009-2025 Movatter.jp