All commit authors signed the Contributor License Agreement.

Thank you!

Please also remove the square brackets: those are another way of saying that the argument is optional, they aren't needed if the default value is given.

This change makes theget docs inconsistent withfromkeys,pop, andsetdefault. Do you want to update those as well?

Thanks for the PR! Changes like this are ... controversial. There's a group of core devs who prefer the(a[, b]) signatures, and there's a groupe of core devs who prefer the(a, b=None) signatures. The problem with the former is that they do not work well withinspect, so a lot of people want to changeinspect instead.

Moreover, this PR introduces an inconsistency when we compareget() to the surrounding documented methods. The "bracket-without-default" notation is predominantly used, soiff this should be changed, one would have to take this whole section into account.

So, sorry, I think we have to reject this particular change for now. IMO, it should not be in the TODO list in the issue; changes like this are controversial, and thus no good match as a beginner PR/issue :(

@encukou and@erlend-aasland - thank you for the feedback! No worries, I wasn't aware of the controversy around those notations. I just saw it in that issue and it looked like a layup, but things are often more complex than they seem. I appreciate the context :)

I just had a talk with Petr, and I see now that this particular change isnot in the controversial camp :) Itdoes make sense to align the docs with the docstring; so let's land this!

I just had a talk with Petr, and I see now that this particular change isnot in the controversial camp :) Itdoes make sense to align the docs with the docstring; so let's land this!

Great to hear! I just updatedget and the other surrounding methods (fromkeys,pop, andsetdefault) for consistency. Let me know if anything looks off.

Wait, one point of confusion - should the dosctring forpop be updated too, to mention that None is the default? Or does the raising of the KeyError cover that?

Wait, one point of confusion - should the dosctring forpop be updated too, to mention that None is the default? Or does the raising of the KeyError cover that?

Well, it is not that easy; you'd have to change the Argument Clinic input and regenerate the parsing code:

So,that change would look like this¹:

diff --git a/Objects/dictobject.c b/Objects/dictobject.cindex 985a326a176..c976a0c868f 100644--- a/Objects/dictobject.c+++ b/Objects/dictobject.c@@ -4378,7 +4378,7 @@ dict_clear_impl(PyDictObject *self) dict.pop      key: object-    default: object = NULL+    default: object = None     /  D.pop(k[,d]) -> v, remove specified key and return the corresponding value.

I think we shouldconsider leaving thepop() change out; what do you think,@encukou? Contrary to the other methods,pop() does not actually default toNone; in the implementation it defaults toNULL.

Except forpop, these look fine to me.

Thank you,@johnlandonwood, and congrats on landing your first PR :)

Thank you,@johnlandonwood, and congrats on landing your first PR :)

No, thanks to you and the others for what you do! Feels great!

Hmm, I think I remember why these got skipped in all of the past sweeps. The issue was that the bracketless form implied that keyword arguments could be used. Also, there was a decision to avoid use/ in signatures in the docs because it tends to confuse users.

Also, it looks like the actual help signatures sometimes look terrible and we don't want that to spill to the main docs:

>>> help(dict.pop)Help on method_descriptor:pop(self, key, default=<unrepresentable>, /) unbound builtins.dict method    D.pop(k[,d]) -> v, remove specified key and return the corresponding value.    If the key is not found, return the default if given; otherwise,    raise a KeyError.

Go ahead and do want you want. I don't have an opinion. I just know that these were intentionally not changed during past sweeps.

GH-119370 is a backport of this pull request to the3.13 branch.

GH-119371 is a backport of this pull request to the3.12 branch.