Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-107262: update Tkinter tests for 8.6.14#119322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
serhiy-storchaka merged 5 commits intopython:mainfromDBJim:main
May 30, 2024

Conversation

DBJim
Copy link
Contributor

@DBJimDBJim commentedMay 21, 2024•
edited by bedevere-appbot
Loading

Update test assertions to pass with the changed behavior in Tk 8.6.14.

These two assertions are now only tested when the fixed Tk version is used, and it now tests for the correct result.

The tests are now passing locally on windows 64 bit when built with 8.6.14, which I hope should allow#116145 to progress for Windows.

Since it only changes the tests, I think news can be skipped.

@DBJim
Copy link
ContributorAuthor

@serhiy-storchaka could you please review?

@serhiy-storchakaserhiy-storchaka self-requested a reviewMay 21, 2024 18:33
@DBJim
Copy link
ContributorAuthor

Hi@serhiy-storchaka, Would you mind taking a look? Let me know if you prefer to approach differently

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for your PR. I will look at this closer after I build Tcl/Tk 8.6.14.

I think that it is worth to keep tests for older Tk versions, which can still be in use. For example:

self.checkParam(widget,'padding', (5,6,7),expected=(5,6,7)ifpatchlevel>= (8,6,14)else ('5','6','7'))

You should also run the tests after manually changingwantobjects = 1 towantobjects = 0 inLib/tkinter/__init__.py (unfortunately there is not option to do this without manual modification of the sources) and ensure that they are still passed.

So the final code could look rather like:

self.checkParam(widget,'padding', (5,6,7),expected=('5','6','7')ifself.wantobjectorpatchlevel< (8,6,14)else (5,6,7))

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I updated tests, so they now pass with older Tcl/Tk.

DBJim reacted with heart emoji
@serhiy-storchaka
Copy link
Member

@DBJim, thank you for your contribution.

Maybe you're new to Git? I noticed that you made these changes in themain branch. This makes it difficult for you to generate other PRs. You should create a new branch from themain branch, commit all changes to that branch, and create a PR from that branch. This allows you to work on several PRs at the same time and preserves yourmain branch.

DBJim reacted with thumbs up emoji

@serhiy-storchakaserhiy-storchakaenabled auto-merge (squash)May 30, 2024 18:44
@serhiy-storchakaserhiy-storchaka merged commit9732ed5 intopython:mainMay 30, 2024
36 checks passed
@miss-islington-app
Copy link

Thanks@DBJim for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 30, 2024
)(cherry picked from commit9732ed5)Co-authored-by: James De Bias <81095953+DBJim@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 30, 2024
)(cherry picked from commit9732ed5)Co-authored-by: James De Bias <81095953+DBJim@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-119806 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 30, 2024
@bedevere-app
Copy link

GH-119807 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelMay 30, 2024
serhiy-storchaka added a commit that referenced this pull requestMay 30, 2024
…H-119806)(cherry picked from commit9732ed5)Co-authored-by: James De Bias <81095953+DBJim@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull requestMay 30, 2024
…H-119807)(cherry picked from commit9732ed5)Co-authored-by: James De Bias <81095953+DBJim@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull requestJul 11, 2024
)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
hugovk pushed a commit to hugovk/cpython that referenced this pull requestFeb 18, 2025
)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
hugovk pushed a commit to hugovk/cpython that referenced this pull requestFeb 18, 2025
)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@hugovk
Copy link
Member

We need to backport this to 3.9, because it's still usingubuntu-20.04 which is deprecated and will be fully unsupported in April:actions/runner-images#11101.

And the upgrade to newer Ubuntu also upgrades Tk.

@hugovkhugovk added needs backport to 3.9only security fixes needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsFeb 18, 2025
@miss-islington-app
Copy link

Thanks@DBJim for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@DBJim for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@DBJim for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 18, 2025
)(cherry picked from commit9732ed5)Co-authored-by: James De Bias <81095953+DBJim@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

GH-130274 is a backport of this pull request to the3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 18, 2025
)(cherry picked from commit9732ed5)Co-authored-by: James De Bias <81095953+DBJim@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-appbedevere-appbot removed the needs backport to 3.10only security fixes labelFeb 18, 2025
@bedevere-app
Copy link

GH-130275 is a backport of this pull request to the3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestFeb 18, 2025
)(cherry picked from commit9732ed5)Co-authored-by: James De Bias <81095953+DBJim@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-appbedevere-appbot removed the needs backport to 3.9only security fixes labelFeb 18, 2025
@bedevere-app
Copy link

GH-130276 is a backport of this pull request to the3.11 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.11only security fixes labelFeb 18, 2025
hugovk pushed a commit that referenced this pull requestFeb 19, 2025
…130276)Co-authored-by: James De Bias <81095953+DBJim@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
hugovk added a commit that referenced this pull requestFeb 19, 2025
…130274)Co-authored-by: James De Bias <81095953+DBJim@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
hugovk added a commit that referenced this pull requestFeb 19, 2025
…130275)Co-authored-by: James De Bias <81095953+DBJim@users.noreply.github.com>Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@DBJim@serhiy-storchaka@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp