Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-119035: Add Ctrl+← and Ctrl+→ word-skipping keybindings to new repl#119248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 1 commit intopython:mainfromoptim-ally:repl-word-skipping
May 21, 2024

Conversation

optim-ally
Copy link
Contributor

@optim-allyoptim-ally commentedMay 20, 2024•
edited by bedevere-appbot
Loading

Added missing keybindings forCtrl+← andCtrl+→ inreader.py.

These should map toctrl left andctrl right but, as Tomas mentioned in#119035, those are treated as invalid characters by the keymap translator. This is due to an incorrect assumption thatCtrl can only be combined with a single character, so the logic inkeymap.py needs a small change too.

As far as I can tell, "left" and "right" are the only only multi-character keynames that we need to map, so I've just added an explicit check for those two.

P.S. first-time contributor at PyCon US! Lmk if I've missed any steps in creating the PR.

danielhollas reacted with hooray emoji
@ghost
Copy link

ghost commentedMay 20, 2024•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! Thanks@optim-ally!

optim-ally reacted with laugh emoji
@ambvambv merged commit0398d93 intopython:mainMay 21, 2024
@lysnikolaoulysnikolaou added the needs backport to 3.13bugs and security fixes labelMay 21, 2024
@miss-islington-app
Copy link

Thanks@optim-ally for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 21, 2024
…ew repl (pythonGH-119248)add word-skipping ctrl keybindings to new repl(cherry picked from commit0398d93)Co-authored-by: Alastair Stanley <alastairstanley@ntlworld.com>
@bedevere-app
Copy link

GH-119323 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 21, 2024
@hroncok
Copy link
Contributor

Thank you@optim-ally and congrats on your first commit to Python :)

optim-ally reacted with hooray emoji

@optim-allyoptim-ally deleted the repl-word-skipping branchMay 21, 2024 20:20
lysnikolaou pushed a commit that referenced this pull requestMay 21, 2024
…new repl (GH-119248) (#119323)add word-skipping ctrl keybindings to new repl(cherry picked from commit0398d93)Co-authored-by: Alastair Stanley <alastairstanley@ntlworld.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lysnikolaoulysnikolaoulysnikolaou approved these changes

Assignees
No one assigned
Labels
skip newstopic-replRelated to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@optim-ally@hroncok@lysnikolaou@ambv
[8]ページ先頭
©2009-2025 Movatter.jp