Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-118912: Remove description of issue fixed in 3.5 from autospeccing guide#119232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ghost commentedMay 20, 2024 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
All commit authors signed the Contributor License Agreement. |
nedbat approved these changesMay 20, 2024
willingc approved these changesMay 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks@shaunagm
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2024
…eccing guide (pythonGH-119232)* Remove description of issue fixed in 3.5 from autospeccing guide* Make autospeccing note text more succint and lint whitespace* Add linting changes (missed in last commit)---------(cherry picked from commit7e57640)Co-authored-by: Shauna <shaunagm@gmail.com>Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2024
…eccing guide (pythonGH-119232)* Remove description of issue fixed in 3.5 from autospeccing guide* Make autospeccing note text more succint and lint whitespace* Add linting changes (missed in last commit)---------(cherry picked from commit7e57640)Co-authored-by: Shauna <shaunagm@gmail.com>Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
GH-119283 is a backport of this pull request to the3.12 branch. |
GH-119284 is a backport of this pull request to the3.13 branch. |
willingc added a commit that referenced this pull requestMay 20, 2024
…peccing guide (GH-119232) (#119283)gh-118912: Remove description of issue fixed in 3.5 from autospeccing guide (GH-119232)* Remove description of issue fixed in 3.5 from autospeccing guide* Make autospeccing note text more succint and lint whitespace* Add linting changes (missed in last commit)---------(cherry picked from commit7e57640)Co-authored-by: Shauna <shaunagm@gmail.com>Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
willingc added a commit that referenced this pull requestMay 20, 2024
…peccing guide (GH-119232) (#119284)gh-118912: Remove description of issue fixed in 3.5 from autospeccing guide (GH-119232)* Remove description of issue fixed in 3.5 from autospeccing guide* Make autospeccing note text more succint and lint whitespace* Add linting changes (missed in last commit)---------(cherry picked from commit7e57640)Co-authored-by: Shauna <shaunagm@gmail.com>Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
…eccing guide (python#119232)* Remove description of issue fixed in 3.5 from autospeccing guide* Make autospeccing note text more succint and lint whitespace* Add linting changes (missed in last commit)---------Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Note: I am a first-time contributor, so apologies if I've missed some important norms or processes.
This is an attempt tofix#118912 by removing the description of a bug that was removed in Python 3.5. I noticed that elsewhere in the documentation there were comments about when something had been added or removed or changed, so I tried using that here. Not sure if that was actually appropriate.
I had one other question: the autospeccing guide feels a little out of place here. Everything else seems to be primarily for reference, while this guide feels like more of a howto. Should it be moved to a howto section, and merely linked here? If we want to keep it in this part of the docs, should it be moved next to create_autospec or even submerged into it? Eager to get your thoughts on this question, and to get overall feedback on this PR.
📚 Documentation preview 📚:https://cpython-previews--119232.org.readthedocs.build/