Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-119205: Fix autocompletion bug in new repl#119229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 15 commits intopython:mainfromkoxudaxi:fix-issue-119205
May 21, 2024

Conversation

koxudaxi
Copy link
Contributor

@koxudaxikoxudaxi commentedMay 20, 2024
edited by bedevere-appbot
Loading

If the interpreter shows a warning, the new repl prompt cursor moves after the warning.

@ghost
Copy link

ghost commentedMay 20, 2024
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@lysnikolaou
Copy link
Member

@koxudaxi Can you please rebase onto main and move the tests to the newly createdtest_pyrepl directory?

koxudaxi reacted with thumbs up emoji

@ambvambv requested a review fromrhettinger as acode ownerMay 21, 2024 18:46
Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM! 🎉

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@lysnikolaoulysnikolaou added the topic-replRelated to the interactive shell labelMay 21, 2024
@ambvambvenabled auto-merge (squash)May 21, 2024 19:12
@koxudaxi
Copy link
ContributorAuthor

@ambv@lysnikolaou
Thank you for reviewing and rebasing my PR.
I apologize I was moving to Pittsburgh airport from the conference center.

@ambv
Copy link
Contributor

ambv commentedMay 21, 2024
edited
Loading

@koxudaxi let the tests complete, don't rebase unless there are conflicts.

koxudaxi reacted with thumbs up emoji

@ambvambv merged commit506b1a3 intopython:mainMay 21, 2024
@koxudaxikoxudaxi deleted the fix-issue-119205 branchMay 21, 2024 23:35
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Debian root 3.x has failed when building commit506b1a3.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/8076) and take a look at the build logs.
  4. Check if the failure is related to this commit (506b1a3) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/8076

Summary of the results of the build (if available):

Click to see traceback logs
Note:switching to '506b1a3ff66a41c72d205c8e4cba574e439d8e76'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 506b1a3ff6 gh-119205: Fix autocompletion bug in new repl (#119229)Switched to and reset branch 'main'configure:WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)configure:WARNING: pkg-config is missing. Some dependencies may not be detected correctly.make:*** wait: No child processes.  Stop.make:*** Waiting for unfinished jobs....make:*** wait: No child processes.  Stop.Cannot open file '/root/buildarea/3.x.angelico-debian-amd64/build/test-results.xml' for upload

@ambv
Copy link
Contributor

The buildbot failure is an unrelated timeout:

command timed out: 1800 seconds without output running [b'make', b'buildbottest', b'TESTOPTS=-j2 --junit-xml test-results.xml ${BUILDBOT_TESTOPTS}', b'TESTPYTHONOPTS=', b'TESTTIMEOUT=1200'], attempting to kill
koxudaxi reacted with eyes emoji

@lysnikolaoulysnikolaou added the needs backport to 3.13bugs and security fixes labelMay 22, 2024
@miss-islington-app
Copy link

Thanks@koxudaxi for the PR, and@ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

koxudaxi reacted with heart emoji

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 22, 2024
(cherry picked from commit506b1a3)Co-authored-by: Koudai Aono <koxudaxi@gmail.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
@bedevere-app
Copy link

GH-119407 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 22, 2024
lysnikolaou pushed a commit that referenced this pull requestMay 22, 2024
…9407)(cherry picked from commit506b1a3)Co-authored-by: Koudai Aono <koxudaxi@gmail.com>Co-authored-by: Łukasz Langa <lukasz@langa.pl>
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
Co-authored-by: Łukasz Langa <lukasz@langa.pl>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lysnikolaoulysnikolaoulysnikolaou approved these changes

@rhettingerrhettingerAwaiting requested review from rhettinger

Assignees
No one assigned
Labels
skip newstopic-replRelated to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@koxudaxi@lysnikolaou@ambv@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp