Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-115119: Fall back to bundled libmpdec if system libmpdec is not found#119196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedMay 20, 2024•
edited
Loading

$ brew unlink libmpdec$ ./configure --with-system-libmpdec| grep -E"(decimal|mpdec)"checkingfor --with-system-libmpdec... yescheckingfor libmpdec>= 2.5.0... noconfigure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduledforremovalin Python 3.15)checkingfor --with-decimal-contextvar... yescheckingfor decimal libmpdec machine... universalcheckingfor stdlib extension module _decimal... yes$ grep'DECIMAL_.*FLAGS' MakefileMODULE__DECIMAL_CFLAGS=-I$(srcdir)/Modules/_decimal/libmpdec -DUNIVERSAL=1MODULE__DECIMAL_LDFLAGS=-lm$(LIBMPDEC_A)$ ./configure| grep -E"(decimal|mpdec)"checkingfor --with-system-libmpdec... yescheckingfor libmpdec>= 2.5.0... noconfigure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduledforremovalin Python 3.15)checkingfor --with-decimal-contextvar... yescheckingfor decimal libmpdec machine... universalcheckingfor stdlib extension module _decimal... yes$ grep'DECIMAL_.*FLAGS' MakefileMODULE__DECIMAL_CFLAGS=-I$(srcdir)/Modules/_decimal/libmpdec -DUNIVERSAL=1MODULE__DECIMAL_LDFLAGS=-lm$(LIBMPDEC_A)$ ./configure --without-system-libmpdec| grep -E"(decimal|mpdec)"checkingfor --with-system-libmpdec... noconfigure: WARNING: the bundled copy of libmpdecimal is scheduledforremovalin Python 3.15; consider using a system installed mpdecimal library.checkingfor --with-decimal-contextvar... yescheckingfor decimal libmpdec machine... universalcheckingfor stdlib extension module _decimal... yes$ grep ‘DECIMAL_.*FLAGS’ MakefileMODULE__DECIMAL_CFLAGS=-I$(srcdir)/Modules/_decimal/libmpdec -DUNIVERSAL=1MODULE__DECIMAL_LDFLAGS=-lm$(LIBMPDEC_A)$ brew link libmpdec$ ./configure --with-system-libmpdec| grep -E"(decimal|mpdec)"checkingfor --with-system-libmpdec... yescheckingfor libmpdec>= 2.5.0... yescheckingfor --with-decimal-contextvar... yescheckingfor stdlib extension module _decimal... yes$ grep ‘DECIMAL_.*FLAGS’ MakefileMODULE__DECIMAL_CFLAGS=-I/opt/homebrew/Cellar/mpdecimal/4.0.0/includeMODULE__DECIMAL_LDFLAGS=-L/opt/homebrew/Cellar/mpdecimal/4.0.0/lib -lmpdec -lm

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@erlend-aasland for commitc537d8b 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 20, 2024
Copy link
Member

@ned-deilyned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks!

@erlend-aasland
Copy link
ContributorAuthor

erlend-aasland commentedMay 20, 2024•
edited
Loading

Thanks for the review, Ned! FTR, the buildbot failures all seem unrelated1

Footnotes

  1. buildbot/PPC64LE Fedora Stable Refleaks PR is another regression I introduced in sqlite3; PR is alreadyup merged 😄↩

@erlend-aasland
Copy link
ContributorAuthor

I'll wait for Zach to chime in before landing.

@vstinner
Copy link
Member

cc@hroncok who had issues with this issue.

@erlend-aasland
Copy link
ContributorAuthor

Merging, as per Ned's comment on Discord.

ned-deily reacted with thumbs up emoji

@erlend-aaslanderlend-aasland merged commit642b25b intopython:mainMay 20, 2024
121 of 126 checks passed
@erlend-aaslanderlend-aasland deleted the libmpdec-fallback branchMay 20, 2024 14:58
@miss-islington-app

This comment was marked as outdated.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2024
…not found (pythonGH-119196)(cherry picked from commit642b25b)Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-app
Copy link

GH-119217 is a backport of this pull request to the3.13 branch.

ned-deily reacted with thumbs up emoji

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 20, 2024
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull requestMay 20, 2024
erlend-aasland added a commit that referenced this pull requestMay 20, 2024
… not found (GH-119196) (#119217)(cherry picked from commit642b25b)Co-authored-by: Erlend E. Aasland <erlend@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ned-deilyned-deilyned-deily approved these changes

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

@zwarezwareAwaiting requested review from zware

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@erlend-aasland@bedevere-bot@vstinner@ned-deily
[8]ページ先頭
©2009-2025 Movatter.jp