Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-119121: Fix and testasync.staggered.staggered_race#119173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 3 commits intopython:mainfromsobolevn:issue-119121
May 20, 2024

Conversation

sobolevn
Copy link
Member

@sobolevnsobolevn commentedMay 19, 2024•
edited by bedevere-appbot
Loading

I've added a couple of tests for this function as well, to prevent simple future regressions.

Please, note that this set of tests is clearly not enough to cover all the cases in this function. Right now it only covers several simple use-cases. In the future we can also test:

  • loop= argument
  • Cleanups of running tasks
  • __debug__ route
  • delay corner cases
  • etc

But, I think that testing green path is good enough for now.
I can commit more tests in the next PRs, since they will require quite a lot of effort.

Refs#114282
This PR does need a 3.13 backport.

Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@sobolevnsobolevn merged commit16b46eb intopython:mainMay 20, 2024
@miss-islington-app
Copy link

Thanks@sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2024
…nGH-119173)(cherry picked from commit16b46eb)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

GH-119206 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 20, 2024
sobolevn added a commit that referenced this pull requestMay 20, 2024
…19173) (#119206)gh-119121: Fix and test `async.staggered.staggered_race` (GH-119173)(cherry picked from commit16b46eb)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 FreeBSD14 3.13 has failed when building commit3a8ab99.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1481/builds/48) and take a look at the build logs.
  4. Check if the failure is related to this commit (3a8ab99) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1481/builds/48

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):  File"<frozen getpath>", line355, in<module>ValueError:embedded null byteWarning -- Uncaught thread exception: InterpreterErrorException in thread Thread-188 (task):RuntimeError:error evaluating pathTraceback (most recent call last):  File"/home/buildbot/buildarea/3.13.opsec-fbsd14/build/Lib/threading.py", line1039, in_bootstrap_innerself.run()~~~~~~~~^^  File"/home/buildbot/buildarea/3.13.opsec-fbsd14/build/Lib/threading.py", line990, inrunself._target(*self._args,**self._kwargs)~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^  File"/home/buildbot/buildarea/3.13.opsec-fbsd14/build/Lib/test/test_interpreters/test_stress.py", line29, intask    interp= interpreters.create()  File"/home/buildbot/buildarea/3.13.opsec-fbsd14/build/Lib/test/support/interpreters/__init__.py", line76, increateid= _interpreters.create(reqrefs=True)interpreters.InterpreterError:interpreter creation failedk

Kronuz pushed a commit to Kronuz/cpython that referenced this pull requestMay 20, 2024
…pythonGH-119173) (python#119206)pythongh-119121: Fix and test `async.staggered.staggered_race` (pythonGH-119173)(cherry picked from commit16b46eb)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@gvanrossumgvanrossumgvanrossum approved these changes

@1st11st1Awaiting requested review from 1st11st1 is a code owner

@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

@kumaraditya303kumaraditya303Awaiting requested review from kumaraditya303kumaraditya303 is a code owner

@willingcwillingcAwaiting requested review from willingcwillingc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@sobolevn@bedevere-bot@JelleZijlstra@gvanrossum
[8]ページ先頭
©2009-2025 Movatter.jp