Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
Try to repair oddball test bots timing out in test_int#119166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
timing out during test_int after ecd8664 (asymptoticallyfaster str->int). Best guess is that they don't build theC _decimal module. So require that module in the mostlikely tests to time out then. Flying mostly blind, though!
ba8af84
intopython:mainUh oh!
There was an error while loading.Please reload this page.
This could be, in part, due to the recent (just prior to 3.13.0b1) change (#118539) to |
Thanks for the info, Ned! I tuned all that out while it was happening. On the one hand, I'm happy to do what it takes so that Python doesn'tneed On the other ... It's not just C v Python speed at work. |
ned-deily commentedMay 19, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yes, I think part of the issue is the name of the configure option: @Yhg1s, I think we should consider doing something for 3.13 to make this less of a potential footgun for our downstream builders and users, if nothing else, making it less easy to overlook the fact that |
The |
I mentioned this to Ned yesterday in person, but yeah, I think the temporary solution is to fall back to the bundled version if the system-installed version isn't available. We may want to warn that the bundled version is going away if that's still the plan, and we can warn more aggressively going forward (even going so far as to reflect that decimal is using the bundled libmpdec in the module somewhere, so we can have tests start failing without breaking the build), but that's for later I think. |
Various test bots (outside the ones GH normally runs) are timing out during test_int after ecd8664 (asymptotically faster str->int). Best guess is that they don't build the C _decimal module. So require that module in the most likely tests to time out then. Flying mostly blind, though!
Various test bots (outside the ones GH normally runs) are timing out during test_int afterecd8664 (asymptotically faster str->int). Best guess is that they don't build the C _decimal module. So require that module in the most likely tests to time out then. Flying mostly blind, though!