Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
Fix version number in use_load_tests deprecation reference#119151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Fix version number in use_load_tests deprecation reference#119151
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Deprecation took place ind78742a (3.5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice catch,
...there is a directive called.. deprecated:: which might be useful here.
| @@ -1739,7 +1739,7 @@ unittest | |||
| * Undocumented :meth:`TestLoader.loadTestsFromModule | |||
| <unittest.TestLoader.loadTestsFromModule>` parameter *use_load_tests* | |||
| (deprecated and ignored since Python 3.2). | |||
| (deprecated and ignored since Python 3.5). | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice catch thank you.
Could you put this in a.. deprecated:: 3.5 directive ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for taking a look. I only see uses of that directive in the actual documentation relating to the method itself, not here in the changelog. I'm reluctant to add the first such directive in this /whatsnew directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fair enough. I guess this may be impacted by the bigger topic mentioned in#109843 (comment) having to do with moving deprecation and removal items out of news.
| @@ -1739,7 +1739,7 @@ unittest | |||
| * Undocumented :meth:`TestLoader.loadTestsFromModule | |||
| <unittest.TestLoader.loadTestsFromModule>` parameter *use_load_tests* | |||
| (deprecated and ignored since Python 3.2). | |||
| (deprecated and ignored since Python 3.5). | |||
| * An alias of the :class:`~unittest.TextTestResult` class: | |||
| ``_TextTestResult`` (deprecated in Python 3.2). | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This might also be a candidate for..deprecated :: 3.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
Thanks@jacobtylerwalls for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
GH-119386 is a backport of this pull request to the3.13 branch. |
GH-119387 is a backport of this pull request to the3.12 branch. |
Uh oh!
There was an error while loading.Please reload this page.
Deprecation took place ind78742a (3.5)
📚 Documentation preview 📚:https://cpython-previews--119151.org.readthedocs.build/