Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-119132: Update sys.version to identify free-threaded or not.#119134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
13 commits Select commitHold shift + click to select a range
dd95b0e gh-119132: Update buildinfo to identify free-threaded or not.
corona1004f5a79 Update test
corona105034205 Only for free-threading
corona10f135b42 Update Lib/platform.py
corona1094cbf8d Update Lib/platform.py
corona10e2d60ba Address code review
corona104bb1d66 Add comment
corona10a7e3697 Fix docs
corona10f54cef4 nit
corona10e0b3370 Address code review
corona10c3fd105 Address code review
corona10a29a17d Increase the buffer
corona10267a0fd Update Lib/platform.py
corona10File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
24 changes: 15 additions & 9 deletionsLib/platform.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletionsMisc/NEWS.d/next/Build/2024-05-17-19-53-27.gh-issue-119132.wepPgM.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Update :data:`sys.version` to identify whether the build is default build or | ||
| free-threading build. Patch By Donghee Na. |
9 changes: 7 additions & 2 deletionsPython/getversion.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -6,15 +6,20 @@ | ||
| #include "patchlevel.h" | ||
| static int initialized = 0; | ||
| static char version[300]; | ||
| void _Py_InitVersion(void) | ||
| { | ||
| if (initialized) { | ||
| return; | ||
| } | ||
| initialized = 1; | ||
| #ifdef Py_GIL_DISABLED | ||
| const char *buildinfo_format = "%.80s experimental free-threading build (%.80s) %.80s"; | ||
vstinner marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| #else | ||
| const char *buildinfo_format = "%.80s (%.80s) %.80s"; | ||
| #endif | ||
| PyOS_snprintf(version, sizeof(version), buildinfo_format, | ||
| PY_VERSION, Py_GetBuildInfo(), Py_GetCompiler()); | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.