Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
Improvepyrepl type-annotation coverage#119081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
pablogsal approved these changesMay 17, 2024
Thanks@AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 22, 2024
(cherry picked from commit033f5c8)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
GH-119415 is a backport of this pull request to the3.13 branch. |
lysnikolaou pushed a commit that referenced this pull requestMay 22, 2024
(cherry picked from commit033f5c8)Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Closed
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some more low-hanging fruit to improve the coverage of type annotations in
Lib/_pyrepl, which should improve mypy's ability to spot issues in CI. This gets the number of mypy complaints down from 35 to 14 if you runmypy --config-file Lib/_pyrepl/mypy.ini --disallow-untyped-calls