Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-58933: Make pdb return to caller frame correctly when f_trace is not set#118979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 2 commits intopython:mainfromgaogaotiantian:pdb-trace-missing
May 13, 2024

Conversation

gaogaotiantian
Copy link
Member

@gaogaotiantiangaogaotiantian commentedMay 12, 2024•
edited by bedevere-appbot
Loading

For commands likenext,return,until on a return event, iff_trace of the previous frame is not set, the command will not stop at the previous frame. A similar issue is fixed forstep, we are generalizing that fix to commands other thancontinue.

@gaogaotiantiangaogaotiantian added 3.12only security fixes 3.13bugs and security fixes labelsMay 12, 2024
@gaogaotiantian
Copy link
MemberAuthor

Hi@iritkatriel , this is a bug fix (a rather important one I think) and maybe it should be backported?

@iritkatrieliritkatriel added the needs backport to 3.12only security fixes labelMay 13, 2024
@miss-islington-app
Copy link

Thanks@gaogaotiantian for the PR, and@iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry,@gaogaotiantian and@iritkatriel, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker f526314194f7fd15931025f8a4439c1765666e42 3.12

@gaogaotiantian
Copy link
MemberAuthor

Asmain is 3.14 now, we should probably need to backport to 3.13 too?

@gaogaotiantian
Copy link
MemberAuthor

And I'll work on the cherry pick.

@iritkatrieliritkatriel added the needs backport to 3.13bugs and security fixes labelMay 13, 2024
@miss-islington-app
Copy link

Thanks@gaogaotiantian for the PR, and@iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 13, 2024
…e is not set (pythonGH-118979)(cherry picked from commitf526314)Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@bedevere-app
Copy link

GH-119007 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 13, 2024
@bedevere-app
Copy link

GH-119008 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelMay 13, 2024
@gaogaotiantiangaogaotiantian deleted the pdb-trace-missing branchMay 13, 2024 18:17
iritkatriel pushed a commit that referenced this pull requestMay 13, 2024
…ce is not set (GH-118979) (#119007)gh-58933: Make pdb return to caller frame correctly when f_trace is not set (GH-118979)(cherry picked from commitf526314)Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
iritkatriel pushed a commit that referenced this pull requestMay 13, 2024
…ce is not set (GH-118979) (#119008)* [3.12]gh-58933: Make pdb return to caller frame correctly when f_trace is not set (GH-118979)(cherry picked from commitf526314)Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees

@iritkatrieliritkatriel

Labels
3.12only security fixes3.13bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@gaogaotiantian@iritkatriel
[8]ページ先頭
©2009-2025 Movatter.jp