I didn't use it, but LGTM. Except I would preferparse_range thanget_range.

Thanks for the suggestions, I've made some changes based on them.

Aaaand some final comments I think. Sorry to break down my reviews like that but I usually comment incrementally but I don't want people to be frustrated by my nitpicking (also, I don't see the point of reviewing something that could change after addressing other comments).

No worries, and thanks a lot for the detailed suggestions for my code! Your suggestions are very helpful.

@arhadthedev
@JelleZijlstra
This would close a nearly4 year old issue and enhance cpython with one of the most basic features of HTTP servers, range requests.

Please review if possible.

Ping! (I hope it's ok to ping every 6 months or so, especially if it seems to be so nearly done :) )

All commit authors signed the Contributor License Agreement.

Does this need to be changed?
We can increase the number but I wouldn't bother (check git blame to see when it was last updated for instance)

This field has not been changed for 17 years😂. I guess we can leave it as is.

FTR, can we actually a link that that comment to indicate the rationale of this choice? Since the PR has quite a lot of comments, it'd be easier if we want to find the rationale in the future.

Which specific comment do you refer to?

BTW, I realized thatparse_range() collapses(None, None) toNone simply becausebytes=- is not a valid range-specifier syntax, and I edited comments in code to indicate this.

Which specific comment do you refer to?

This one:#118949 (comment) or#118949 (comment).

@vadmium
Please forgive me for pinging, you are probably swamped in work! If you have time to look at this <200 LoC PR any time I'd be giggling in glee!

Oh... I suddenly realized that Python 3.14 has already reached beta freeze, but this PR hasn't been merged yet, should I change the target version number to 3.15?

Yes, I'm sorry I forgot about it.

No worries, I didn't notice that either. Let me change it tomorrow.

Sorry for the thread bump:
What future Python version is being targeted at the moment for the release of this good feature?

What future Python version is being targeted at the moment for the release of this good feature?

Since we forgot to merge it in before the 3.14 feature freeze, you'll only see it in Python 3.15 at the earliest (a little over a year from now).

Let me change it tomorrow.

Sorry I haven't changed it yet. I see that there are still a lot of TODOs in the 3.15 whatsnew file, and I'm worried that there will be conflicts soon in the future if I change it now. Maybe I'll wait for the 3.15 whatsnew file to have a little bit more content.

Don't worry about the todos. Just add a new http (or http.client I don't remember where the code is) section under improved modules (it there isn't oe already).