Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-118928: sqlite3: disallow sequences of params with named placeholders#118929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedMay 10, 2024•
edited by github-actionsbot
Loading

@erlend-aasland
Copy link
ContributorAuthor

cc.@felixxm

@erlend-aasland
Copy link
ContributorAuthor

@hugovk, would you mind taking a look at the What's New entry?

erlend-aaslandand others added2 commitsMay 11, 2024 16:43
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@erlend-aasland
Copy link
ContributorAuthor

Thanks, Hugo!

hugovk reacted with thumbs up emoji

Copy link
Contributor

@felixxmfelixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@erlend-aasland Thanks 👍

@erlend-aasland
Copy link
ContributorAuthor

Thanks, Mariusz!

@erlend-aasland
Copy link
ContributorAuthor

Thanks, Serhiy. I made the diff slightly nicer with642015e. Enabling auto-merge.

@erlend-aaslanderlend-aaslandenabled auto-merge (squash)May 14, 2024 15:50
@erlend-aaslanderlend-aasland merged commitd8e0e00 intopython:mainMay 14, 2024
@erlend-aaslanderlend-aasland deleted the sqlite/incorrectly-bound-params branchMay 14, 2024 16:10
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull requestMay 20, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
…ceholders (python#118929)Follow-up ofpythongh-101693. The previous DeprecationWarning is replaced with raising sqlite3.ProgrammingError.Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@berkerpeksagberkerpeksagAwaiting requested review from berkerpeksagberkerpeksag is a code owner

+1 more reviewer

@felixxmfelixxmfelixxm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

sqlite3: disallow using a sequence of params with named placeholders

4 participants

@erlend-aasland@hugovk@felixxm@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp