NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

[3.13] gh-117657: Fix QSBR race condition (GH-118843)#118905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

colesbury merged 1 commit intopython:3.13frommiss-islington:backport-33d2019-3.13

May 10, 2024

Merged

[3.13] gh-117657: Fix QSBR race condition (GH-118843)#118905

colesbury merged 1 commit intopython:3.13frommiss-islington:backport-33d2019-3.13

May 10, 2024

Conversation

Copy link

Contributor

miss-islington commentedMay 10, 2024•
edited by bedevere-appbot
Loading

_Py_qsbr_unregister is called when the PyThreadState is already
detached, so the access totstate->qsbr isn't safe without locking the
shared mutex. Grab thestruct _qsbr_shared from the interpreter
instead.
(cherry picked from commit33d2019)

Co-authored-by: Alex Turneralexturner@meta.com

Issue:Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

pythongh-117657: Fix QSBR race condition (pythonGH-118843)

97ca83d

`_Py_qsbr_unregister` is called when the PyThreadState is alreadydetached, so the access to `tstate->qsbr` isn't safe without locking theshared mutex. Grab the `struct _qsbr_shared` from the interpreterinstead.(cherry picked from commit33d2019)Co-authored-by: Alex Turner <alexturner@meta.com>