Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
[3.13] gh-118789: Restore hidden_PyWeakref_ClearRef
(GH-118797)#118903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
_PyWeakref_ClearRef was previously exposed in the public C-API, althoughit begins with an underscore and is not documented. It's used by a fewC-API extensions. There is currently no alternative public API that canreplace its use._PyWeakref_ClearWeakRefsExceptCallbacks is the only thread-safe way touse _PyWeakref_ClearRef in the free-threaded build. This exposes the Csymbol, but does not make the API public.(cherry picked from commitdb5af7d)Co-authored-by: Sam Gross <colesbury@gmail.com>
This was referencedMay 10, 2024
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
_PyWeakref_ClearRef was previously exposed in the public C-API, although
it begins with an underscore and is not documented. It's used by a few
C-API extensions. There is currently no alternative public API that can
replace its use.
_PyWeakref_ClearWeakRefsExceptCallbacks is the only thread-safe way to
use _PyWeakref_ClearRef in the free-threaded build. This exposes the C
symbol, but does not make the API public.
(cherry picked from commitdb5af7d)
Co-authored-by: Sam Grosscolesbury@gmail.com
_PyWeakref_ClearRef
and_PyWeakref_ClearWeakRefsExceptCallbacks
should be exposed in 3.13 #118789