There are some uses of this function in the wild, which this change would break...https://github.com/wyfo/apischema/blob/d48cc010c417e9c49db25b7a8683621b3c305b44/apischema/typing.py#L59-L62

And we could also fix the test failure over attyping_extensions with this diff:

--- a/src/typing_extensions.py+++ b/src/typing_extensions.py@@ -2836,7 +2836,8 @@ else:          return tuple(parameters)-    typing._collect_parameters = _collect_parameters+    if not _PEP_696_IMPLEMENTED:+        typing._collect_parameters = _collect_parameters

It's true that making a change in CPython rather thantyping_extensions has the advantage that already-released versions oftyping_extensions are fixed as well to-be-released versions oftyping_extensions. But I think already-released versions oftyping_extensions are badly broken anyway on Python 3.13, due to the error pointed out inpython/typing_extensions#377 (comment)

But I think already-released versions oftyping_extensions are badly broken anyway on Python 3.13, due to the error pointed out inpython/typing_extensions#377 (comment)

I think that error shows up only if you usetyping_extensions.TypeVar though, while the error this PR fixes breaks any use of Generic aftertyping_extensions is imported, which feels much worse.

There are some uses of this function in the wild, which this change would break...https://github.com/wyfo/apischema/blob/d48cc010c417e9c49db25b7a8683621b3c305b44/apischema/typing.py#L59-L62

I think we could address this by keeping an alias_collect_parameters = _collect_type_parameters (or a wrapper function that raises DeprecationWarning).

Okay, sounds reasonable.

I think we could address this by keeping an alias_collect_parameters = _collect_type_parameters (or a wrapper function that raises DeprecationWarning).

Or we could do this in the__getattr__ method down at the bottom? (Withdo_the_deprecation_warning() replaced by the appropriate logic to do a deprecation warning)

--- a/Lib/typing.py+++ b/Lib/typing.py@@ -3770,6 +3770,9 @@ def __getattr__(attr):     elif attr in {"ContextManager", "AsyncContextManager"}:         import contextlib         obj = _alias(getattr(contextlib, f"Abstract{attr}"), 2, name=attr, defaults=(bool | None,))+    elif attr == "_collect_parameters":+        do_the_deprecation_warning()+        return _collect_type_parameters     else:         raise AttributeError(f"module {__name__!r} has no attribute {attr!r}")     globals()[attr] = obj

Thanks@JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

GH-118917 is a backport of this pull request to the3.13 branch.

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu NoGIL 3.13 has failed when building commitb3074f0.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1422/builds/9) and take a look at the build logs.
4. Check if the failure is related to this commit (b3074f0) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1422/builds/9

Failed tests:

• test_eintr
• test_math

Failed subtests:

• test_flock -main.FNTLEINTRTest.test_flock
• test_all - test.test_eintr.EINTRTests.test_all
• test_wait_integer - test.test_multiprocessing_spawn.test_misc.TestWait.test_wait_integer
• test_map_timeout - test.test_concurrent_futures.test_process_pool.ProcessPoolSpawnProcessPoolExecutorTest.test_map_timeout
• test_lockf -main.FNTLEINTRTest.test_lockf

Summary of the results of the build (if available):

==

Traceback (most recent call last):  File"/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_eintr.py", line532, intest_lockfself._lock(fcntl.lockf,"lockf")~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^  File"/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_eintr.py", line517, in_lockraiseException("failed to sync child in%.1f sec"% dt)Exception:failed to sync child in 300.5 secTraceback (most recent call last):  File"/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/test_eintr.py", line17, intest_all    script_helper.run_test_script(script)~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^  File"/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/support/script_helper.py", line316, inrun_test_scriptraiseAssertionError(f"{name} failed")AssertionError:script _test_eintr.py failedTraceback (most recent call last):  File"/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_multiprocessing.py", line5176, intest_wait_integerself.assertLess(delta, expected+2)~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^AssertionError:5.133446088992059 not less than 5Traceback (most recent call last):  File"/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_eintr.py", line535, intest_flockself._lock(fcntl.flock,"flock")~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^  File"/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/_test_eintr.py", line517, in_lockraiseException("failed to sync child in%.1f sec"% dt)Exception:failed to sync child in 300.5 secTraceback (test.test_zipimport.CompressedZipImportTestCase.testTraceback) ... okTraceback (test.test_zipimport.UncompressedZipImportTestCase.testTraceback) ... okTraceback (most recent call last):  File"/home/ubuntu/buildarea/3.13.itamaro-ubuntu-aws.nogil/build/Lib/test/test_concurrent_futures/executor.py", line71, intest_map_timeoutself.assertEqual([None,None], results)~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^AssertionError:Lists differ: [None, None] != []