Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Renamenotimplemented_methods intonodefault_methods#118896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
sobolevn merged 1 commit intopython:mainfromsobolevn:rename-nodefault-methods
May 10, 2024

Conversation

sobolevn
Copy link
Member

This naming is probably a left-over from copy-pasting theNotImplemented implementation. It should be fixed.

Copy link
Member

@JelleZijlstraJelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oops, thanks. Let's backport this in case we need to tweak the implementation of NoDefault more.

AlexWaygood reacted with thumbs up emoji
@JelleZijlstraJelleZijlstra added the needs backport to 3.13bugs and security fixes labelMay 10, 2024
@sobolevnsobolevnenabled auto-merge (squash)May 10, 2024 12:40
@sobolevnsobolevn merged commit004db21 intopython:mainMay 10, 2024
@miss-islington-app
Copy link

Thanks@sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 10, 2024
…8896)(cherry picked from commit004db21)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-app
Copy link

GH-118898 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 10, 2024
sobolevn added a commit that referenced this pull requestMay 10, 2024
…18896) (#118898)Rename `notimplemented_methods` into `nodefault_methods` (GH-118896)(cherry picked from commit004db21)Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@sobolevn@JelleZijlstra@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp