Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-119185: Fix typo in_pyrepl.pager:tempfilepager should betempfile_pager#118881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JelleZijlstra merged 4 commits intopython:mainfromSachaa-Thanasius:patch-1
May 20, 2024
Merged

gh-119185: Fix typo in_pyrepl.pager:tempfilepager should betempfile_pager#118881

JelleZijlstra merged 4 commits intopython:mainfromSachaa-Thanasius:patch-1
May 20, 2024

Conversation

Sachaa-Thanasius
Copy link
Contributor

@Sachaa-ThanasiusSachaa-Thanasius commentedMay 10, 2024•
edited
Loading

The function name has an underscore. Without this, calling help can cause an exception.

Should be reproducible by callinghelp() in the repl on Windows. I personally found it by calling it onsysconfig.get_config_var.

Doesn’t seem worthy of a news entry.

stonebig reacted with thumbs up emoji
The name with no underscore doesn't exist.
@ghost
Copy link

ghost commentedMay 10, 2024•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@Eclips4Eclips4 changed the titleFix typo in_pyrepl.pager:tempfilepager should betempfile_pagergh-119185: Fix typo in_pyrepl.pager:tempfilepager should betempfile_pagerMay 19, 2024
@Eclips4Eclips4 added the needs backport to 3.13bugs and security fixes labelMay 19, 2024
@Eclips4Eclips4 requested a review frompablogsalMay 19, 2024 20:51
@miss-islington-app
Copy link

Thanks@Sachaa-Thanasius for the PR, and@JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

Sachaa-Thanasius reacted with heart emoji

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 20, 2024
…be `tempfile_pager` (pythonGH-118881)Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`The name with no underscore doesn't exist.(cherry picked from commit05e1dce)Co-authored-by: Thanos <111999343+Sachaa-Thanasius@users.noreply.github.com>
@bedevere-app
Copy link

GH-119211 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 20, 2024
@Sachaa-ThanasiusSachaa-Thanasius deleted the patch-1 branchMay 20, 2024 14:54
@Sachaa-ThanasiusSachaa-Thanasius restored the patch-1 branchMay 20, 2024 14:55
@Sachaa-ThanasiusSachaa-Thanasius deleted the patch-1 branchMay 20, 2024 14:55
JelleZijlstra pushed a commit that referenced this pull requestMay 20, 2024
… be `tempfile_pager` (GH-118881) (#119211)Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`The name with no underscore doesn't exist.(cherry picked from commit05e1dce)Co-authored-by: Thanos <111999343+Sachaa-Thanasius@users.noreply.github.com>
@ambvambv added the topic-replRelated to the interactive shell labelMay 23, 2024
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
…be `tempfile_pager` (python#118881)Fix typo in `_pyrepl.pager`: `tempfilepager` should be `tempfile_pager`The name with no underscore doesn't exist.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@Eclips4Eclips4Eclips4 approved these changes

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

Assignees
No one assigned
Labels
skip newstopic-replRelated to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@Sachaa-Thanasius@Eclips4@ambv@JelleZijlstra
[8]ページ先頭
©2009-2025 Movatter.jp