Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-118876: Set ns.temp before invoking its is_absolute method#118880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 1 commit intopython:mainfromi-shenl:fix-issue-118876
May 13, 2024

Conversation

i-shenl
Copy link
Contributor

@i-shenli-shenl commentedMay 10, 2024
edited by bedevere-appbot
Loading

Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.

@i-shenli-shenl requested a review froma team as acode ownerMay 10, 2024 06:15
@ghost
Copy link

ghost commentedMay 10, 2024
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Comment on lines -628 to -629
# Put temp on a Dev Drive for speed if we're copying to one.
# If not, the regular temp dir will have to do.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can you move this as well?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Done!

@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.
@bedevere-app
Copy link

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

@zoobazooba merged commitd8a82cc intopython:mainMay 13, 2024
@zoobazooba added needs backport to 3.12only security fixes needs backport to 3.13bugs and security fixes labelsMay 13, 2024
@miss-islington-app
Copy link

Thanks@i-shenl for the PR, and@zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks@i-shenl for the PR, and@zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 13, 2024
…nGH-118880)Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.(cherry picked from commitd8a82cc)Co-authored-by: I-Shen Leong <i-shenl@activestate.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 13, 2024
…nGH-118880)Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.(cherry picked from commitd8a82cc)Co-authored-by: I-Shen Leong <i-shenl@activestate.com>
@bedevere-app
Copy link

GH-118994 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelMay 13, 2024
@bedevere-app
Copy link

GH-118995 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 13, 2024
zooba pushed a commit that referenced this pull requestMay 13, 2024
Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.(cherry picked from commitd8a82cc)Co-authored-by: I-Shen Leong <i-shenl@activestate.com>
zooba pushed a commit that referenced this pull requestMay 13, 2024
Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.(cherry picked from commitd8a82cc)Co-authored-by: I-Shen Leong <i-shenl@activestate.com>
estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
…nGH-118880)Fixes an AttributeError that occurs when checking if ns.temp is an absolute path during building from source on Windows.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@zoobazoobazooba left review comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@i-shenl@zooba

[8]ページ先頭

©2009-2025 Movatter.jp