NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

[3.13] gh-117657: Replace TSAN suppresions with more specific rules (GH-118722)#118870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

colesbury merged 1 commit intopython:3.13frommiss-islington:backport-98ff3f6-3.13

May 9, 2024

Merged

[3.13] gh-117657: Replace TSAN suppresions with more specific rules (GH-118722)#118870

colesbury merged 1 commit intopython:3.13frommiss-islington:backport-98ff3f6-3.13

May 9, 2024

Conversation

Copy link

Contributor

miss-islington commentedMay 9, 2024•
edited by bedevere-appbot
Loading

Usingrace: filters out warnings if the function appears anywhere in
the stack trace. This can hide a lot of unrelated warnings, especially
for a function like_PyEval_EvalFrameDefault, which is somewhere on
the stack more often than not.

Change all free-threaded suppressions torace_top:, which only matches
the top frame, and add any new suppressions this exposes.
(cherry picked from commit98ff3f6)

Co-authored-by: Brett Simmersswtaarrs@users.noreply.github.com

Issue:Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

pythongh-117657: Replace TSAN suppresions with more specific rules (p…

1b8df26

…ythonGH-118722)Using `race:` filters out warnings if the function appears anywhere inthe stack trace. This can hide a lot of unrelated warnings, especiallyfor a function like `_PyEval_EvalFrameDefault`, which is somewhere onthe stack more often than not.Change all free-threaded suppressions to `race_top:`, which only matchesthe top frame, and add any new suppressions this exposes.(cherry picked from commit98ff3f6)Co-authored-by: Brett Simmers <swtaarrs@users.noreply.github.com>