Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-117657: Fix data races reported by TSAN oninterp->threads.main#118865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
colesbury merged 4 commits intopython:mainfrommpage:gh-117657-tsan-is-running-main
May 10, 2024

Conversation

mpage
Copy link
Contributor

@mpagempage commentedMay 9, 2024•
edited by bedevere-appbot
Loading

Use relaxed loads/stores when reading/writing to this field.This fixes races likehttps://gist.github.com/mpage/e07497ad8dd444a789ff306cb7996acc
@mpagempage requested a review fromcolesburyMay 9, 2024 20:24
@mpagempage marked this pull request as ready for reviewMay 9, 2024 20:24
Copy link
Contributor

@colesburycolesbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good to me.

Can we remove any TSan suppressions after this change? I'm merging#118722 now, so you might want to wait a little bit and then mergemain into this PR.

mpage reacted with thumbs up emoji
@colesburycolesbury added the needs backport to 3.13bugs and security fixes labelMay 9, 2024
@mpage
Copy link
ContributorAuthor

Sounds good. I'll wait until you merge#118722 then update this PR to remove the appropriate suppressions.

@colesburycolesbury merged commit22d5185 intopython:mainMay 10, 2024
@miss-islington-app
Copy link

Thanks@mpage for the PR, and@colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 10, 2024
…main` (pythonGH-118865)Use relaxed loads/stores when reading/writing to this field.(cherry picked from commit22d5185)Co-authored-by: mpage <mpage@meta.com>
@bedevere-app
Copy link

GH-118904 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 10, 2024
colesbury pushed a commit that referenced this pull requestMay 10, 2024
….main` (GH-118865) (#118904)Use relaxed loads/stores when reading/writing to this field.(cherry picked from commit22d5185)Co-authored-by: mpage <mpage@meta.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@colesburycolesburycolesbury approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mpage@colesbury
[8]ページ先頭
©2009-2025 Movatter.jp