NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

gh-118846: Fix free-threading test failures when run sequentially#118864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

colesbury merged 4 commits intopython:mainfromcolesbury:gh-118846-all-tests

May 10, 2024

Merged

gh-118846: Fix free-threading test failures when run sequentially#118864

colesbury merged 4 commits intopython:mainfromcolesbury:gh-118846-all-tests

May 10, 2024

Conversation

Copy link

Contributor

colesbury commentedMay 9, 2024•
edited by bedevere-appbot
Loading

The free-threaded build currently immortalizes some objects once the first thread is started. This can lead to test failures depending on the order in which tests are run. This PR addresses those failures by suppressing immortalization or skipping the affected tests.

Issue:Freethreading build fails -m test --pgo: test_ordered_dict and test_struct failed #118846

pythongh-118846: Fix free-threading test failures when run sequentially

852175f

The free-threaded build currently immortalizes some objects once thefirst thread is started. This can lead to test failures depending on theorder in which tests are run. This PR addresses those failures bysuppressing immortalization or skipping the affected tests.

colesbury added tests

Tests in the Lib/test dir

topic-free-threading needs backport to 3.13bugs and security fixes labels

May 9, 2024

colesbury requested a review fromDinoV

May 9, 2024 19:31

colesbury requested review fromericsnowcurrently,gvanrossum andmarkshannon ascode owners

May 9, 2024 19:31

bedevere-appbot added the awaiting core review label

May 9, 2024

bedevere-appbot mentioned this pull request

May 9, 2024

Freethreading build fails -m test --pgo: test_ordered_dict and test_struct failed#118846

Closed

colesbury added the skip news label

May 9, 2024

Copy link

ContributorAuthor

colesbury commentedMay 9, 2024

@hroncok - this should address the remaining test failures in conjunction with#118862

DinoV approved these changes

May 9, 2024

View reviewed changes

Copy link

Contributor

DinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

bedevere-appbot added awaiting merge and removed awaiting core review labels

May 9, 2024

Copy link

Contributor

hroncok commentedMay 9, 2024•
edited
Loading

I still have:

======================================================================ERROR: test_builtin_with_more_than_four_children (test.test_pydoc.test_pydoc.PydocDocTest.test_builtin_with_more_than_four_children)Tests help on builtin object which have more than four child classes.----------------------------------------------------------------------Traceback (most recent call last):  File ".../cpython/Lib/test/test_pydoc/test_pydoc.py", line 537, in test_builtin_with_more_than_four_children    text = doc.docclass(object)  File ".../cpython/Lib/pydoc.py", line 1424, in docclass    subclasses = sorted(        (str(cls.__name__) for cls in type.__subclasses__(object)         if not cls.__name__.startswith("_") and cls.__module__ == "builtins"),        key=str.lower    )  File ".../cpython/Lib/pydoc.py", line 1426, in <genexpr>    if not cls.__name__.startswith("_") and cls.__module__ == "builtins"),                                            ^^^^^^^^^^^^^^  File ".../cpython/Lib/test/test_inspect/test_inspect.py", line 775, in __module__    raise AttributeErrorAttributeError: . Did you mean: '__reduce__'?----------------------------------------------------------------------Ran 108 tests in 1.709sFAILED (errors=1, skipped=3)test test.test_pydoc.test_pydoc failed======================================================================FAIL: test_bug1055820c (test.test_gc.GCTogglingTests.test_bug1055820c)----------------------------------------------------------------------Traceback (most recent call last):  File ".../cpython/Lib/test/test_gc.py", line 1361, in test_bug1055820c    self.fail("gc didn't happen after 10000 iterations")    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: gc didn't happen after 10000 iterations======================================================================FAIL: test_bug1055820d (test.test_gc.GCTogglingTests.test_bug1055820d)----------------------------------------------------------------------Traceback (most recent call last):  File ".../cpython/Lib/contextlib.py", line 85, in inner    return func(*args, **kwds)  File ".../cpython/Lib/test/test_gc.py", line 1429, in test_bug1055820d    self.fail("gc didn't happen after 10000 iterations")    ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^AssertionError: gc didn't happen after 10000 iterations----------------------------------------------------------------------Ran 49 tests in 14.476sFAILED (failures=2, skipped=4)test test_gc failed

Not sure if the pydoc thing is related, but the gc might.

Merge branch 'main' intopythongh-118846-all-tests

923dd2d

Copy link

ContributorAuthor

colesbury commentedMay 9, 2024

The pydoc failure is a funny interaction between tests. Intest_inspect.py, we create a class that raises an error when you access__module__:

cpython/Lib/test/test_inspect/test_inspect.py

Lines 771 to 775 in98ff3f6

	deftest_getfile_class_without_module(self):
	classCM(type):
	@property
	def__module__(cls):
	raiseAttributeError

In the free-threaded build, this class is now immortalized so it's still alive later on whentest_pydoc tries to generate the pydoc for all subclasses ofobject.

colesbury added2 commits

May 9, 2024 22:21

Fix test_pydoc failure

f469a2e

Fix test_gc when run sequentially

0c0c9b4

Copy link

ContributorAuthor

colesbury commentedMay 10, 2024

Ok, I think thetest_pydoc andtest_gc failures are fixed now too.

colesbury merged commitb309c8e intopython:main

May 10, 2024

colesbury deleted the gh-118846-all-tests branch

May 10, 2024 20:29

bedevere-appbot removed the awaiting merge label

May 10, 2024

Copy link

miss-islington-appbot commentedMay 10, 2024

Thanks@colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

May 10, 2024

pythongh-118846: Fix free-threading test failures when run sequential…

305f67e

…ly (pythonGH-118864)The free-threaded build currently immortalizes some objects once thefirst thread is started. This can lead to test failures depending on theorder in which tests are run. This PR addresses those failures bysuppressing immortalization or skipping the affected tests.(cherry picked from commitb309c8e)Co-authored-by: Sam Gross <colesbury@gmail.com>

Copy link

bedevere-appbot commentedMay 10, 2024

GH-118927 is a backport of this pull request to the3.13 branch.

bedevere-appbot removed the needs backport to 3.13bugs and security fixes label

May 10, 2024

colesbury added a commit that referenced this pull request

May 10, 2024

[3.13]gh-118846: Fix free-threading test failures when run sequentia…

cceb758

…lly (GH-118864) (#118927)The free-threaded build currently immortalizes some objects once thefirst thread is started. This can lead to test failures depending on theorder in which tests are run. This PR addresses those failures bysuppressing immortalization or skipping the affected tests.(cherry picked from commitb309c8e)Co-authored-by: Sam Gross <colesbury@gmail.com>

Copy link

Contributor

hroncok commentedMay 10, 2024

This is the only one I got now:

======================================================================ERROR: test_expr_context (test.test_ast.ASTConstructorTests.test_expr_context)----------------------------------------------------------------------Traceback (most recent call last):  File ".../cpython/Lib/test/test_ast.py", line 3042, in test_expr_context    self.assertIsInstance(name.ctx, ast.Load)                          ^^^^^^^^AttributeError: 'Name' object has no attribute 'ctx'----------------------------------------------------------------------Ran 175 tests in 0.765sFAILED (errors=1, skipped=1)

Copy link

ContributorAuthor

colesbury commentedMay 10, 2024

Just checking, this is from./python -m test -W on the 3.13 branch? Is it a debug build?

Copy link

Member

AlexWaygood commentedMay 10, 2024

Note that that AST test was only merged (and backported to 3.13) yesterday in#118854

Copy link

Contributor

hroncok commentedMay 11, 2024

I might have git pulled but forgot to rebuild it. Mea culpa. Trying fresh.

Copy link

Contributor

hroncok commentedMay 11, 2024

All is good now, thank you!

JelleZijlstra mentioned this pull request

May 28, 2024

backport a9a74da 3.13#119642

Closed

estyxx pushed a commit to estyxx/cpython that referenced this pull request

Jul 17, 2024

pythongh-118846: Fix free-threading test failures when run sequential…

b1970ec

…ly (python#118864)The free-threaded build currently immortalizes some objects once thefirst thread is started. This can lead to test failures depending on theorder in which tests are run. This PR addresses those failures bysuppressing immortalization or skipping the affected tests.