Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-118846: Fix PGO tests in free-threaded build#118862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
colesbury merged 1 commit intopython:mainfromcolesbury:gh-118846-pgo-tests
May 9, 2024

Conversation

colesbury
Copy link
Contributor

@colesburycolesbury commentedMay 9, 2024•
edited by bedevere-appbot
Loading

Avoid immortalizing objects in tests that verify garbage collection of classes or modules.

This fixes test_ordered_dict and test_struct.

Avoid immortalizing objects in some tests that test behavior ofcollecting classes or modules.This fixes test_ordered_dict and test_struct.
@colesbury
Copy link
ContributorAuthor

cc@hroncok - I'll look at the other tests next, but this should be enough to fix the PGO build.

@hroncok
Copy link
Contributor

but this should be enough to fix the PGO build.

Indeed it is. Thanks.

Copy link
Contributor

@DinoVDinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@colesburycolesbury merged commit1b1db2f intopython:mainMay 9, 2024
@miss-islington-app
Copy link

Thanks@colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@colesburycolesbury deleted the gh-118846-pgo-tests branchMay 9, 2024 20:06
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 9, 2024
Avoid immortalizing objects in tests that verify garbage collection ofclasses or modules.This fixes test_ordered_dict and test_struct.(cherry picked from commit1b1db2f)Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

GH-118867 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 9, 2024
colesbury added a commit that referenced this pull requestMay 9, 2024
…118867)Avoid immortalizing objects in tests that verify garbage collection ofclasses or modules.This fixes test_ordered_dict and test_struct.(cherry picked from commit1b1db2f)Co-authored-by: Sam Gross <colesbury@gmail.com>
SonicField pushed a commit to SonicField/cpython that referenced this pull requestMay 10, 2024
Avoid immortalizing objects in tests that verify garbage collection ofclasses or modules.This fixes test_ordered_dict and test_struct.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@DinoVDinoVDinoV approved these changes

@hroncokhroncokhroncok approved these changes

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dirtopic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@colesbury@hroncok@DinoV
[8]ページ先頭
©2009-2025 Movatter.jp