Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Revert "gh-115432: Add critical section variant that handles a NULL object (#115433)"#118861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
colesbury merged 1 commit intopython:mainfromcolesbury:gh-115432-revert
May 9, 2024

Conversation

colesbury
Copy link
Contributor

@colesburycolesbury commentedMay 9, 2024•
edited by bedevere-appbot
Loading

This reverts commitad4f909.

This internal API ended up not being used.

…NULL object (python#115433)"This reverts commitad4f909.The API ended up not being used.
@colesbury
Copy link
ContributorAuthor

@Yhg1s - this isn't really a bug fix, but it's definitely not a feature. Would it be appropriate to backport this revert to 3.13?

Copy link
Contributor

@DinoVDinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@Yhg1s
Copy link
Member

Yeah, backporting it to 3.13 is fine until we get to rc1.

colesbury reacted with thumbs up emoji

@colesburycolesbury added the needs backport to 3.13bugs and security fixes labelMay 9, 2024
@colesburycolesbury merged commit46c8081 intopython:mainMay 9, 2024
@colesburycolesbury deleted the gh-115432-revert branchMay 9, 2024 22:33
@miss-islington-app
Copy link

Thanks@colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 9, 2024
…NULL object (pythonGH-115433)" (pythonGH-118861)This reverts commitad4f909.The API ended up not being used.(cherry picked from commit46c8081)Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

GH-118872 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 9, 2024
colesbury added a commit that referenced this pull requestMay 9, 2024
… NULL object (GH-115433)" (GH-118861) (#118872)This reverts commitad4f909.The API ended up not being used.(cherry picked from commit46c8081)Co-authored-by: Sam Gross <colesbury@gmail.com>
SonicField pushed a commit to SonicField/cpython that referenced this pull requestMay 10, 2024
…NULL object (python#115433)" (python#118861)This reverts commitad4f909.The API ended up not being used.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@DinoVDinoVDinoV approved these changes

@Yhg1sYhg1sAwaiting requested review from Yhg1s

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@colesbury@Yhg1s@DinoV
[8]ページ先頭
©2009-2025 Movatter.jp