NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-118771: Ensure names defined in optimizer.h start with Py/_Py#118825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

encukou merged 4 commits intopython:mainfromencukou:private

May 10, 2024

Merged

gh-118771: Ensure names defined in optimizer.h start with Py/_Py#118825

encukou merged 4 commits intopython:mainfromencukou:private

May 10, 2024

Conversation

Copy link

Member

encukou commentedMay 9, 2024•
edited by bedevere-appbot
Loading

optimizer.h is included fromPython.h, and defines some names that can clash with user code. They should be hidden or get thePy/_Py prefix.

This PR:

removes unused struct tags from typedefs:
- struct _bloom_filter
- struct _exit_data
prefixes the remaining names with_Py_:
- uop_get_target
- uop_get_exit_index
- uop_get_jump_target
- uop_get_error_target
- optimize_func typedef
- BLOOM_FILTER_WORDS
- UOP_FORMAT_TARGET
- UOP_FORMAT_EXIT
- UOP_FORMAT_JUMP
- UOP_FORMAT_UNUSED

Perhaps some of these should be in a private header instead?
Or perhaps some should be public?
@markshannon, could you clarify the intent here?

Issue:3.13 adds C macros/functions/types without thePy/_Py prefix #118771

Ensure names defined in optimizer.h start with Py/_Py

c49d473

encukou requested review fromgvanrossum andmarkshannon ascode owners

May 9, 2024 08:52

bedevere-appbot added the awaiting core review label

May 9, 2024

bedevere-appbot mentioned this pull request

May 9, 2024

3.13 adds C macros/functions/types without thePy/_Py prefix#118771

Closed

28 tasks

gvanrossum removed their request for review

May 9, 2024 15:21

Copy link

Member

gvanrossum commentedMay 9, 2024

I'll leave this for@markshannon to review.

Copy link

Member

brandtbucher commentedMay 9, 2024•
edited
Loading

I personally don't think we should be exposing this much of the micro-op format. Can they just be moved topycore_optimizer.h? I forget if the same naming rules apply there.