Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-116984: Make mimalloc header includes relative to the current file#118808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…t fileSome embedders and extensions include parts of the internal API. Thepycore_mimalloc.h file is transitively include by a number of otherinternal headers. This avoids include errors for code that wasalready including those headers.
DinoV approved these changesMay 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM!
71cc065 intopython:main 41 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 9, 2024
…t file (pythonGH-118808)Some embedders and extensions include parts of the internal API. Thepycore_mimalloc.h file is transitively include by a number of otherinternal headers. This avoids include errors for code that wasalready including those headers.(cherry picked from commit71cc065)Co-authored-by: Sam Gross <colesbury@gmail.com>
GH-118866 is a backport of this pull request to the3.13 branch. |
colesbury added a commit that referenced this pull requestMay 9, 2024
…nt file (GH-118808) (#118866)Some embedders and extensions include parts of the internal API. Thepycore_mimalloc.h file is transitively include by a number of otherinternal headers. This avoids include errors for code that wasalready including those headers.(cherry picked from commit71cc065)Co-authored-by: Sam Gross <colesbury@gmail.com>
SonicField pushed a commit to SonicField/cpython that referenced this pull requestMay 10, 2024
…t file (python#118808)Some embedders and extensions include parts of the internal API. Thepycore_mimalloc.h file is transitively include by a number of otherinternal headers. This avoids include errors for code that wasalready including those headers.
Closed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Some embedders and extensions include parts of the internal API. The pycore_mimalloc.h file is transitively include by a number of other internal headers. This avoids include errors for code that was already including those headers.