Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-118789: Restore hidden_PyWeakref_ClearRef#118797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
_PyWeakref_ClearRef was previously exposed in the public C-API, althoughit begins with an underscore and is not documented. It's used by a fewC-API extensions. There is currently no alternative public API that canreplace its use._PyWeakref_ClearWeakRefsExceptCallbacks is the only thread-safe way touse _PyWeakref_ClearRef in the free-threaded build. This exposes the Csymbol, but does not make the API public.
cc@albanD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
My bad - LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Would it be possible to only restore it in Python 3.13 and remove it (do nothing) in Python 3.14, since a replacement is added?
Uh oh!
There was an error while loading.Please reload this page.
That's a question for the C API workgroup. AFAIK, the workflow for 3.13 is to restore the API that causes problems. I don't think 3.14 branching changes that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Thanks@colesbury for the PR, and@encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
_PyWeakref_ClearRef was previously exposed in the public C-API, althoughit begins with an underscore and is not documented. It's used by a fewC-API extensions. There is currently no alternative public API that canreplace its use._PyWeakref_ClearWeakRefsExceptCallbacks is the only thread-safe way touse _PyWeakref_ClearRef in the free-threaded build. This exposes the Csymbol, but does not make the API public.(cherry picked from commitdb5af7d)Co-authored-by: Sam Gross <colesbury@gmail.com>
GH-118903 is a backport of this pull request to the3.13 branch. |
…H-118903)gh-118789: Restore hidden `_PyWeakref_ClearRef` (GH-118797)_PyWeakref_ClearRef was previously exposed in the public C-API, althoughit begins with an underscore and is not documented. It's used by a fewC-API extensions. There is currently no alternative public API that canreplace its use._PyWeakref_ClearWeakRefsExceptCallbacks is the only thread-safe way touse _PyWeakref_ClearRef in the free-threaded build. This exposes the Csymbol, but does not make the API public.(cherry picked from commitdb5af7d)Co-authored-by: Sam Gross <colesbury@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
_PyWeakref_ClearRefwas previously exposed in the public C-API, although it begins with an underscore and is not documented. It's used by a few C-API extensions. There is currently no alternative public API that can replace its use._PyWeakref_ClearRefand_PyWeakref_ClearWeakRefsExceptCallbacksshould be exposed in 3.13 #118789