Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-118760: Restore the default value of tkinter.wantobjects to 1#118784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-118760: Restore the default value of tkinter.wantobjects to 1#118784
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Misc/NEWS.d/3.13.0b1.rst Outdated
| Add support for passing arguments to callbacks registered in the :mod:`tkinter` | ||
| module as various Python objects (``int``, ``float``, ``bytes``, ``tuple``), | ||
| corresponding to the original Tcl value, not just ``str``, and enable this by default. | ||
| To restore the previous behavior set :mod:`!tkinter` module global |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This does not make sense when the value already is 1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It is an edited NEWS entry for 3.13.0b1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The change to 3.13 what's new suggests that the change to wantobjects will be backported also. 'Restoring' 1 to 1 is what I questioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is an edited NEWS entry for 3.13.0b1. We cannot simply remove it, because it is the part of the history, and 3.13.0b1 was already released with the bug.
But I reworded it, focusing on thepossibility to change the behavior and adding that it was changed by default (not for long, for 3.13.0b1 only). So "restoring" here refers to the changed default. How to write this better? Maybe just remove all starting from "To restore"? And add the description of how to enable the experimental feature in the new NEWS entry for 3.13.0b2?
Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
pythonGH-118784)It was set to 2 in65f5e58 (pythonGH-98592).(cherry picked from commite188527)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
GH-119251 is a backport of this pull request to the3.13 branch. |
Uh oh!
There was an error while loading.Please reload this page.
It was set to 2 in65f5e58 (GH-98592).
📚 Documentation preview 📚:https://cpython-previews--118784.org.readthedocs.build/