NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

gh-118772: Allow TypeVars without a default to follow those with a default when constructing aliases#118774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JelleZijlstra merged 2 commits intopython:mainfromJelleZijlstra:relaxdefailt

May 8, 2024

Merged

gh-118772: Allow TypeVars without a default to follow those with a default when constructing aliases#118774

JelleZijlstra merged 2 commits intopython:mainfromJelleZijlstra:relaxdefailt

May 8, 2024

Conversation

Copy link

Member

JelleZijlstra commentedMay 8, 2024•
edited by bedevere-appbot
Loading

Issue:Relax TypeVar default ordering constraints #118772

JelleZijlstra added2 commits

May 8, 2024 09:15

Relax defaults

4e6fdb3

blurb

8ee213b

JelleZijlstra added the needs backport to 3.13bugs and security fixes label

May 8, 2024

JelleZijlstra requested a review fromAlexWaygood as acode owner

May 8, 2024 16:23

bedevere-appbot added the awaiting core review label

May 8, 2024

bedevere-appbot mentioned this pull request

May 8, 2024

Relax TypeVar default ordering constraints#118772

Closed

AlexWaygood approved these changes

May 8, 2024

View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting core review labels

May 8, 2024

JelleZijlstra merged commitaac6b01 intopython:main

May 8, 2024

Copy link

miss-islington-appbot commentedMay 8, 2024

Thanks@JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

bedevere-appbot removed the awaiting merge label

May 8, 2024

JelleZijlstra deleted the relaxdefailt branch

May 8, 2024 16:54

Copy link

bedevere-appbot commentedMay 8, 2024

GH-118776 is a backport of this pull request to the3.13 branch.

bedevere-appbot removed the needs backport to 3.13bugs and security fixes label

May 8, 2024

JelleZijlstra added a commit that referenced this pull request

May 8, 2024

[3.13]gh-118772: Allow TypeVars without a default to follow those wi…

c6680cd

…th a default when constructing aliases (GH-118774) (#118776)(cherry picked from commitaac6b01)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Copy link

Member

AlexWaygood commentedMay 13, 2024

Unfortunately I think it's infeasible to backport this totyping_extensions, unless we can think of some other approach to implement the same behaviour attyping_extensions. Here's the beginnings of atyping_extensions patch:https://github.com/python/typing_extensions/compare/main...AlexWaygood:typing_extensions:646-default-before-nondefault?expand=1. It passes tests on Python 3.11 and 3.12, but starts interfering with thetyping.py internals in some quite fundamental ways on lower versions of Python due to the extensiveness of the monkeypatching. It's plausibly fixable, but it would require even more invasive monkeypatching, and I think it would make the code too fragile.