Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-118507 : Refactornt._path_is*
#118755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Eryk Sun <eryksun@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Eryk Sun <eryksun@gmail.com>
@zooba, I added the test Eryk requested. |
This comment was marked as spam.
This comment was marked as spam.
erlend-aasland commentedMay 21, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
You already have two extremely competent reviewers for this PR: Eryk and Steve. Why are you keeping pinging other core devs? This only creates unneeded noise; please stop it. |
nineteendo commentedMay 21, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
OK, but I'm not sure what Steve is waiting for. I thought we were done here. Could you react with eyes if you saw this? |
Mostly I was waiting for enough free time to give it a proper review - while I get work time to work on Python, it's not strictly my job, so I can't always prioritise reviews over other things. This looks good now. Since we need an additional change for 3.12, we'll need a manual backport for that |
Thanks@nineteendo for the PR, and@zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…r other cases (pythonGH-118755)(cherry picked from commitb641825)Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
Sorry,@nineteendo and@zooba, I could not cleanly backport this to
|
GH-119360 is a backport of this pull request to the3.13 branch. |
GH-119381 is a backport of this pull request to the3.12 branch. |
GH-119381 is a backport of this pull request to the3.12 branch. |
Note that it's not a full backport, as the C implementation of |
GH-119420 is a backport of this pull request to the3.12 branch. |
1 similar comment
GH-119420 is a backport of this pull request to the3.12 branch. |
Do you guys realize this breaks using
|
@zooba, should this be fixed? diff --git a/Modules/posixmodule.c b/Modules/posixmodule.cindex f02b6d1779827f..2a65752d9431fe 100644--- a/Modules/posixmodule.c+++ b/Modules/posixmodule.c@@ -5385,7 +5385,6 @@ _testFileType(path_t *path, int testedType) os._path_exists -> bool path: path_t(allow_fd=True, suppress_value_error=True)- / Test whether a path exists. Returns False for broken symbolic links.@@ -5403,7 +5402,6 @@ os__path_exists_impl(PyObject *module, path_t *path) os._path_lexists -> bool path: path_t(allow_fd=True, suppress_value_error=True)- / Test whether a path exists. Returns True for broken symbolic links. |
@sobolevn is this a problem? |
Uh oh!
There was an error while loading.Please reload this page.
nt._path_is*
&nt._path_[l]exists
#118507