Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-118507 : Refactornt._path_is*#118755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 44 commits intopython:mainfromnineteendo:refactor-nt._path_is
May 21, 2024

Conversation

nineteendo
Copy link
Contributor

@nineteendonineteendo commentedMay 8, 2024
edited by bedevere-appbot
Loading

@nineteendo

This comment was marked as resolved.

@nineteendo

This comment was marked as resolved.

@eryksun

This comment was marked as resolved.

nineteendoand others added2 commitsMay 9, 2024 12:41
Co-authored-by: Eryk Sun <eryksun@gmail.com>
@nineteendo
Copy link
ContributorAuthor

@zooba, I added the test Eryk requested.

@nineteendo

This comment was marked as spam.

@erlend-aasland
Copy link
Contributor

erlend-aasland commentedMay 21, 2024
edited
Loading

You already have two extremely competent reviewers for this PR: Eryk and Steve. Why are you keeping pinging other core devs? This only creates unneeded noise; please stop it.

@nineteendo
Copy link
ContributorAuthor

nineteendo commentedMay 21, 2024
edited
Loading

OK, but I'm not sure what Steve is waiting for. I thought we were done here. Could you react with eyes if you saw this?
I don't want to wait till June 8th before pinging the issue and another week before I can ask on Discourse.

@zooba
Copy link
Member

Mostly I was waiting for enough free time to give it a proper review - while I get work time to work on Python, it's not strictly my job, so I can't always prioritise reviews over other things.

This looks good now. Since we need an additional change for 3.12, we'll need a manual backport for that

@zoobazooba merged commitb641825 intopython:mainMay 21, 2024
@miss-islington-app
Copy link

Thanks@nineteendo for the PR, and@zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 21, 2024
…r other cases (pythonGH-118755)(cherry picked from commitb641825)Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@miss-islington-app
Copy link

Sorry,@nineteendo and@zooba, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.

cherry_picker b64182550f73e556344bd754d32e3be5d22a74e1 3.12

@bedevere-app
Copy link

GH-119360 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 21, 2024
zooba pushed a commit that referenced this pull requestMay 22, 2024
…r cases (GH-118755)(cherry picked from commitb641825)Co-authored-by: Nice Zombies <nineteendo19d0@gmail.com>
@nineteendonineteendo deleted the refactor-nt._path_is branchMay 22, 2024 04:59
nineteendo added a commit to nineteendo/cpython that referenced this pull requestMay 22, 2024
@bedevere-app
Copy link

GH-119381 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelMay 22, 2024
@bedevere-app
Copy link

GH-119381 is a backport of this pull request to the3.12 branch.

@nineteendo
Copy link
ContributorAuthor

Note that it's not a full backport, as the C implementation ofntpath.isjunction() &ntpath.lexists() isn't included yet to minimise the risk of changed behaviour. We can consider backporting them later once we're more confident.

@bedevere-app
Copy link

GH-119420 is a backport of this pull request to the3.12 branch.

1 similar comment
@bedevere-app
Copy link

GH-119420 is a backport of this pull request to the3.12 branch.

estyxx pushed a commit to estyxx/cpython that referenced this pull requestJul 17, 2024
@socal-nerdtastic
Copy link
Contributor

Do you guys realize this breaks usingpath as a kwarg? You may want to update the docs.

os.path.exists(path=".")TypeError: nt._path_exists() takes no keyword arguments
nineteendo reacted with thumbs up emoji

@nineteendo
Copy link
ContributorAuthor

@zooba, should this be fixed?

diff --git a/Modules/posixmodule.c b/Modules/posixmodule.cindex f02b6d1779827f..2a65752d9431fe 100644--- a/Modules/posixmodule.c+++ b/Modules/posixmodule.c@@ -5385,7 +5385,6 @@ _testFileType(path_t *path, int testedType) os._path_exists -> bool      path: path_t(allow_fd=True, suppress_value_error=True)-    /  Test whether a path exists.  Returns False for broken symbolic links.@@ -5403,7 +5402,6 @@ os__path_exists_impl(PyObject *module, path_t *path) os._path_lexists -> bool      path: path_t(allow_fd=True, suppress_value_error=True)-    /  Test whether a path exists.  Returns True for broken symbolic links.

@nineteendo
Copy link
ContributorAuthor

@sobolevn is this a problem?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@graingertgraingertgraingert left review comments

@zoobazoobazooba left review comments

@eryksuneryksuneryksun approved these changes

Assignees

@zoobazooba

Labels
3.12only security fixes3.13bugs and security fixes3.14bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@nineteendo@eryksun@zooba@erlend-aasland@socal-nerdtastic@graingert

[8]ページ先頭

©2009-2025 Movatter.jp