Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
bpo-36003: change socketserver.TCPServer reuse_addr and backlog default options#11875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- allow_reuse_address from False to True on POSIX- request_queue_size from 5 to 0
Uh oh!
There was an error while loading.Please reload this page.
allow_reuse_address = False | ||
allow_reuse_address = \ | ||
os.name not in ('nt', 'cygwin') and hasattr(socket, 'SO_REUSEADDR') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why the OS check here? IsSO_REUSEADDR
available but not appropriate for use on Windows? If so, I suggest adding a comment.
Also, why useos.name
rather thansys.platform
?
@vstinner, why did you close this with no comment, while the bpo issue is still open? |
Could this be due to the renaming of the "master" branch to "main"? |
I didn't touch this PR. The PR was likely closed when the master branch was renamed to main, because the original branch no longer exists. |
Uh oh!
There was an error while loading.Please reload this page.
https://bugs.python.org/issue36003