Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-117657: Replace TSAN suppresions with more specific rules#118722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
colesbury merged 8 commits intopython:mainfromswtaarrs:cpython-tsan-suppressions
May 9, 2024

Conversation

swtaarrs
Copy link
Member

Usingrace: filters out warnings if the function appears anywhere in the stack trace. This can hide a lot of unrelated warnings, especially for a function like_PyEval_EvalFrameDefault, which is somewhere on the stack more often than not.

Change all free-threaded suppressions torace_top:, which only matches the top frame, and add any new suppressions this exposes. I iterated the test suite under TSAN until it could go 5 times in a row without any new warnings.

@mpage
Copy link
Contributor

mpage commentedMay 7, 2024
edited
Loading

It looks like the free-threading TSAN tests are failing.

@swtaarrs
Copy link
MemberAuthor

Tests are passing now but@mpage pointed out that I should probably do some more stress-testing of this before landing, since there are likely more warnings that just show up less frequently.

@colesbury
Copy link
Contributor

colesbury commentedMay 7, 2024
edited
Loading

I'm seeing a race sometimes reported intest_io.test_daemon_threads_shutdown_stdout_deadlock betweenPyThreadState_Clear andtstate_activate:

https://gist.github.com/colesbury/c0a6edcdf7e909191490cedd3873a062

EDIT: there are a few variations of this, and I think something likerace:_PyThreadState_Attach (instead ofrace_top) is the way to go.

swtaarrs reacted with thumbs up emoji

@colesbury
Copy link
Contributor

Another race betweentype_modified_unlocked (typeobject.c:960:20) andsubtype_dealloc (typeobject.c:2296:36) when running test_httpservers.test_authorization.

Copy link
Contributor

@mpagempage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@colesburycolesbury merged commit98ff3f6 intopython:mainMay 9, 2024
@miss-islington-app
Copy link

Thanks@swtaarrs for the PR, and@colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 9, 2024
…ythonGH-118722)Using `race:` filters out warnings if the function appears anywhere inthe stack trace. This can hide a lot of unrelated warnings, especiallyfor a function like `_PyEval_EvalFrameDefault`, which is somewhere onthe stack more often than not.Change all free-threaded suppressions to `race_top:`, which only matchesthe top frame, and add any new suppressions this exposes.(cherry picked from commit98ff3f6)Co-authored-by: Brett Simmers <swtaarrs@users.noreply.github.com>
@bedevere-app
Copy link

GH-118870 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 9, 2024
colesbury pushed a commit that referenced this pull requestMay 9, 2024
…H-118722) (#118870)Using `race:` filters out warnings if the function appears anywhere inthe stack trace. This can hide a lot of unrelated warnings, especiallyfor a function like `_PyEval_EvalFrameDefault`, which is somewhere onthe stack more often than not.Change all free-threaded suppressions to `race_top:`, which only matchesthe top frame, and add any new suppressions this exposes.(cherry picked from commit98ff3f6)Co-authored-by: Brett Simmers <swtaarrs@users.noreply.github.com>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotwasm32-wasi 3.x has failed when building commit98ff3f6.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1046/builds/5179) and take a look at the build logs.
  4. Check if the failure is related to this commit (98ff3f6) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1046/builds/5179

Failed tests:

  • test_statistics
  • test_math

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 5, done.remote:Counting objects:  20% (1/5)remote:Counting objects:  40% (2/5)remote:Counting objects:  60% (3/5)remote:Counting objects:  80% (4/5)remote:Counting objects: 100% (5/5)remote:Counting objects: 100% (5/5), done.remote:Compressing objects:  25% (1/4)remote:Compressing objects:  50% (2/4)remote:Compressing objects:  75% (3/4)remote:Compressing objects: 100% (4/4)remote:Compressing objects: 100% (4/4), done.remote:Total 5 (delta 1), reused 3 (delta 1), pack-reused 0From https://github.com/python/cpython * branch                  main       -> FETCH_HEADNote:switching to '98ff3f65c0232f31df89ebb52b244625ec9e3eb6'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 98ff3f65c0 gh-117657: Replace TSAN suppresions with more specific rules (#118722)Switched to and reset branch 'main'configure:WARNING: no system libmpdecimal found; unable to build _decimalconfigure:WARNING: using cross tools not prefixed with host tripletconfigure:WARNING: no system libmpdecimal found; unable to build _decimalIn file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]  130 | #  define htole32(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here   43 | #define htole32(x) (uint32_t)(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]  131 | #  define le32toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here   44 | #define le32toh(x) (uint32_t)(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]  132 | #  define htobe32(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here   37 | #define htobe32(x) __bswap32(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]  138 | #  define be32toh(x) (htobe32((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here   38 | #define be32toh(x) __bswap32(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]  140 | #  define htole64(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here   45 | #define htole64(x) (uint64_t)(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]  141 | #  define le64toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here   46 | #define le64toh(x) (uint64_t)(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]  142 | #  define htobe64(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here   39 | #define htobe64(x) __bswap64(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]  149 | #  define be64toh(x) (htobe64((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here   40 | #define be64toh(x) __bswap64(x)|^8 warnings generated.In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]  130 | #  define htole32(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here   43 | #define htole32(x) (uint32_t)(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]  131 | #  define le32toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here   44 | #define le32toh(x) (uint32_t)(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]  132 | #  define htobe32(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here   37 | #define htobe32(x) __bswap32(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]  138 | #  define be32toh(x) (htobe32((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here   38 | #define be32toh(x) __bswap32(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]  140 | #  define htole64(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here   45 | #define htole64(x) (uint64_t)(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]  141 | #  define le64toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here   46 | #define le64toh(x) (uint64_t)(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]  142 | #  define htobe64(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here   39 | #define htobe64(x) __bswap64(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]  149 | #  define be64toh(x) (htobe64((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here   40 | #define be64toh(x) __bswap64(x)|^8 warnings generated.In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]  130 | #  define htole32(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here   43 | #define htole32(x) (uint32_t)(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]  131 | #  define le32toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here   44 | #define le32toh(x) (uint32_t)(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]  132 | #  define htobe32(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here   37 | #define htobe32(x) __bswap32(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]  138 | #  define be32toh(x) (htobe32((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here   38 | #define be32toh(x) __bswap32(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]  140 | #  define htole64(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here   45 | #define htole64(x) (uint64_t)(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]  141 | #  define le64toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here   46 | #define le64toh(x) (uint64_t)(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]  142 | #  define htobe64(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here   39 | #define htobe64(x) __bswap64(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]  149 | #  define be64toh(x) (htobe64((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here   40 | #define be64toh(x) __bswap64(x)|^8 warnings generated.../../Modules/expat/xmlparse.c:7839:11: warning: format specifies type 'int' but the argument has type 'ptrdiff_t' (aka 'long') [-Wformat] 7838 |           " (+" EXPAT_FMT_PTRDIFF_T("6") " bytes %s|%d, xmlparse.c:%d) %*s\"",|~~~~~~~~~~~~~~~~~~~~~~~~ 7839 |           bytesMore, (account == XML_ACCOUNT_DIRECT) ? "DIR" : "EXP",|^~~~~~~~~1 warning generated.../../Modules/_testinternalcapi/test_critical_sections.c:151:1: warning: unused function 'thread_critical_sections' [-Wunused-function]  151 | thread_critical_sections(void *arg)|^~~~~~~~~~~~~~~~~~~~~~~~1 warning generated.../../Modules/posixmodule.c:7847:1: warning: unused function 'warn_about_fork_with_threads' [-Wunused-function] 7847 | warn_about_fork_with_threads(const char* name)|^~~~~~~~~~~~~~~~~~~~~~~~~~~~1 warning generated.In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]  130 | #  define htole32(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here   43 | #define htole32(x) (uint32_t)(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]  131 | #  define le32toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here   44 | #define le32toh(x) (uint32_t)(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]  132 | #  define htobe32(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here   37 | #define htobe32(x) __bswap32(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]  138 | #  define be32toh(x) (htobe32((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here   38 | #define be32toh(x) __bswap32(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]  140 | #  define htole64(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here   45 | #define htole64(x) (uint64_t)(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]  141 | #  define le64toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here   46 | #define le64toh(x) (uint64_t)(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]  142 | #  define htobe64(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here   39 | #define htobe64(x) __bswap64(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]  149 | #  define be64toh(x) (htobe64((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here   40 | #define be64toh(x) __bswap64(x)|^8 warnings generated.Kill <WorkerThread #1 running test=test_math pid=1372091 time=25 min> process groupKill <WorkerThread #1 running test=test_statistics pid=1389956 time=25 min> process groupmake:*** [Makefile:2206: buildbottest] Error 2Cannot open file '/home/buildbot/buildarea/3.x.bcannon-wasi.wasi.debug/build/build/cross-build/wasm32-wasi/test-results.xml' for upload

@colesbury
Copy link
Contributor

The buildbot failure looks unrelated

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotwasm32-wasi 3.13 has failed when building commit982c73a.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1502/builds/12) and take a look at the build logs.
  4. Check if the failure is related to this commit (982c73a) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1502/builds/12

Failed tests:

  • test_statistics
  • test_math

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 5, done.remote:Counting objects:  20% (1/5)remote:Counting objects:  40% (2/5)remote:Counting objects:  60% (3/5)remote:Counting objects:  80% (4/5)remote:Counting objects: 100% (5/5)remote:Counting objects: 100% (5/5), done.remote:Compressing objects:  25% (1/4)remote:Compressing objects:  50% (2/4)remote:Compressing objects:  75% (3/4)remote:Compressing objects: 100% (4/4)remote:Compressing objects: 100% (4/4), done.remote:Total 5 (delta 1), reused 2 (delta 1), pack-reused 0From https://github.com/python/cpython * branch                  3.13       -> FETCH_HEADNote:switching to '982c73a33edf6c1348812c1794a95c20c0c2d906'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 982c73a33e [3.13] gh-117657: Replace TSAN suppresions with more specific rules (GH-118722) (#118870)Switched to and reset branch '3.13'configure:WARNING: no system libmpdecimal found; unable to build _decimalconfigure:WARNING: using cross tools not prefixed with host tripletconfigure:WARNING: no system libmpdecimal found; unable to build _decimalIn file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]  130 | #  define htole32(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here   43 | #define htole32(x) (uint32_t)(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]  131 | #  define le32toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here   44 | #define le32toh(x) (uint32_t)(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]  132 | #  define htobe32(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here   37 | #define htobe32(x) __bswap32(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]  138 | #  define be32toh(x) (htobe32((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here   38 | #define be32toh(x) __bswap32(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]  140 | #  define htole64(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here   45 | #define htole64(x) (uint64_t)(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]  141 | #  define le64toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here   46 | #define le64toh(x) (uint64_t)(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]  142 | #  define htobe64(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here   39 | #define htobe64(x) __bswap64(x)|^In file included from ../../Modules/md5module.c:46:In file included from ../../Modules/_hacl/Hacl_Hash_MD5.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]  149 | #  define be64toh(x) (htobe64((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here   40 | #define be64toh(x) __bswap64(x)|^8 warnings generated.In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]  130 | #  define htole32(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here   43 | #define htole32(x) (uint32_t)(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]  131 | #  define le32toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here   44 | #define le32toh(x) (uint32_t)(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]  132 | #  define htobe32(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here   37 | #define htobe32(x) __bswap32(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]  138 | #  define be32toh(x) (htobe32((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here   38 | #define be32toh(x) __bswap32(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]  140 | #  define htole64(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here   45 | #define htole64(x) (uint64_t)(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]  141 | #  define le64toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here   46 | #define le64toh(x) (uint64_t)(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]  142 | #  define htobe64(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here   39 | #define htobe64(x) __bswap64(x)|^In file included from ../../Modules/sha1module.c:47:In file included from ../../Modules/_hacl/Hacl_Hash_SHA1.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]  149 | #  define be64toh(x) (htobe64((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here   40 | #define be64toh(x) __bswap64(x)|^8 warnings generated.In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]  130 | #  define htole32(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here   43 | #define htole32(x) (uint32_t)(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]  131 | #  define le32toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here   44 | #define le32toh(x) (uint32_t)(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]  132 | #  define htobe32(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here   37 | #define htobe32(x) __bswap32(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]  138 | #  define be32toh(x) (htobe32((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here   38 | #define be32toh(x) __bswap32(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]  140 | #  define htole64(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here   45 | #define htole64(x) (uint64_t)(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]  141 | #  define le64toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here   46 | #define le64toh(x) (uint64_t)(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]  142 | #  define htobe64(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here   39 | #define htobe64(x) __bswap64(x)|^In file included from ../../Modules/sha3module.c:59:In file included from ../../Modules/_hacl/Hacl_Hash_SHA3.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]  149 | #  define be64toh(x) (htobe64((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here   40 | #define be64toh(x) __bswap64(x)|^8 warnings generated.../../Modules/expat/xmlparse.c:7839:11: warning: format specifies type 'int' but the argument has type 'ptrdiff_t' (aka 'long') [-Wformat] 7838 |           " (+" EXPAT_FMT_PTRDIFF_T("6") " bytes %s|%d, xmlparse.c:%d) %*s\"",|~~~~~~~~~~~~~~~~~~~~~~~~ 7839 |           bytesMore, (account == XML_ACCOUNT_DIRECT) ? "DIR" : "EXP",|^~~~~~~~~1 warning generated.../../Modules/_testinternalcapi/test_critical_sections.c:151:1: warning: unused function 'thread_critical_sections' [-Wunused-function]  151 | thread_critical_sections(void *arg)|^~~~~~~~~~~~~~~~~~~~~~~~1 warning generated.../../Modules/posixmodule.c:7847:1: warning: unused function 'warn_about_fork_with_threads' [-Wunused-function] 7847 | warn_about_fork_with_threads(const char* name)|^~~~~~~~~~~~~~~~~~~~~~~~~~~~1 warning generated.In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:130:11: warning: 'htole32' macro redefined [-Wmacro-redefined]  130 | #  define htole32(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:43:9: note: previous definition is here   43 | #define htole32(x) (uint32_t)(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:131:11: warning: 'le32toh' macro redefined [-Wmacro-redefined]  131 | #  define le32toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:44:9: note: previous definition is here   44 | #define le32toh(x) (uint32_t)(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:132:11: warning: 'htobe32' macro redefined [-Wmacro-redefined]  132 | #  define htobe32(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:37:9: note: previous definition is here   37 | #define htobe32(x) __bswap32(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:138:11: warning: 'be32toh' macro redefined [-Wmacro-redefined]  138 | #  define be32toh(x) (htobe32((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:38:9: note: previous definition is here   38 | #define be32toh(x) __bswap32(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:140:11: warning: 'htole64' macro redefined [-Wmacro-redefined]  140 | #  define htole64(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:45:9: note: previous definition is here   45 | #define htole64(x) (uint64_t)(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:141:11: warning: 'le64toh' macro redefined [-Wmacro-redefined]  141 | #  define le64toh(x) (x)|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:46:9: note: previous definition is here   46 | #define le64toh(x) (uint64_t)(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:142:11: warning: 'htobe64' macro redefined [-Wmacro-redefined]  142 | #  define htobe64(x)                                                           \|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:39:9: note: previous definition is here   39 | #define htobe64(x) __bswap64(x)|^In file included from ../../Modules/sha2module.c:48:In file included from ../../Modules/_hacl/Hacl_Hash_SHA2.h:35:In file included from ../../Modules/_hacl/include/krml/types.h:12:../../Modules/_hacl/include/krml/lowstar_endianness.h:149:11: warning: 'be64toh' macro redefined [-Wmacro-redefined]  149 | #  define be64toh(x) (htobe64((x)))|^/opt/wasi-sdk-21.0/bin/../share/wasi-sysroot/include/endian.h:40:9: note: previous definition is here   40 | #define be64toh(x) __bswap64(x)|^8 warnings generated.Kill <WorkerThread #1 running test=test_math pid=1437972 time=25 min> process groupKill <WorkerThread #2 running test=test_statistics pid=1466484 time=25 min> process groupmake:*** [Makefile:2206: buildbottest] Error 2Cannot open file '/home/buildbot/buildarea/3.13.bcannon-wasi.wasi.debug/build/build/cross-build/wasm32-wasi/test-results.xml' for upload

SonicField pushed a commit to SonicField/cpython that referenced this pull requestMay 10, 2024
…ython#118722)Using `race:` filters out warnings if the function appears anywhere inthe stack trace. This can hide a lot of unrelated warnings, especiallyfor a function like `_PyEval_EvalFrameDefault`, which is somewhere onthe stack more often than not.Change all free-threaded suppressions to `race_top:`, which only matchesthe top frame, and add any new suppressions this exposes.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mpagempagempage approved these changes

@colesburycolesburycolesbury approved these changes

@corona10corona10Awaiting requested review from corona10

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@swtaarrs@mpage@colesbury@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp