Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-109975: Update 'What's New in Python 3.13' for beta#118694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| Improve validation logic in the C implementation of:meth:`datetime.fromisoformat` | ||
| to better handle invalid years. Patch by Vlad Efanov. | ||
| Improve validation logic in the C implementation of | ||
| :meth:`datetime.datetime.fromisoformat` to better handle invalid years. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do you know why these weren't caught on the PR adding them? Is there some configuration change we can make so that NEWS entries get linted properly by Sphinx?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We do lint them with Sphinx Lint, but that doesn't catch everything, especially not bad references.
We only check for warnings from a Sphinx build in files underDoc/:
cpython/Doc/tools/check-warnings.py
Lines 212 to 216 inc4f9823
| all_rst= { | |
| str(rst) | |
| forrstinPath("Doc/").rglob("*.rst") | |
| ifrst.parts[1]notinEXCLUDE_SUBDIRS | |
| } |
We ignore those that are in.nitignore because they've not been "cleaned" yet, because we don't want to hassle people over warnings which they didn't introduce.
Similarly, we ignore the news files, because during the Sphinx build, they get compiled into a giant 45k linebuild/NEWS which has 700+ warnings (and growing, because we don't check them).
And so we don't want to warn for every single PR that adds a small NEWS blurb about those 700 warnings that they didn't introduce.
New entries are added to the top of the compiled NEWS file. One option would be to add a check to ensure the top X lines remain clean. Most NEWS entries are under 10 lines long, and the biggest right now is 18 lines, so checking something like the top 200 or so would prevent new warnings being introduced.
I started work on this in February, seehugovk#61. I'll pick this up again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please see PR#119221.
Uh oh!
There was an error while loading.Please reload this page.
Plus fix some Sphinx warnings in the NEWS changelog (there are hundreds more because we don't check them in CI).
📚 Documentation preview 📚:https://cpython-previews--118694.org.readthedocs.build/