Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-118518: RenamePYTHONPERFJITSUPPORT and-X perfjit with underscores#118693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
PYTHONPERFJITSUPPORT and-X perfjitPYTHONPERFJITSUPPORT and-X perfjit with underscorespablogsal approved these changesMay 7, 2024
The TSAN job timed out:https://github.com/python/cpython/actions/runs/8983317059/job/24672835971?pr=118693 I've restarted it. |
0485922 intopython:main 38 checks passed
Uh oh!
There was an error while loading.Please reload this page.
SonicField pushed a commit to SonicField/cpython that referenced this pull requestMay 8, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR renames:
PYTHONPERFJITSUPPORT->PYTHON_PERF_JIT_SUPPORT-X perfjit->-X perf_jitFrom Python 3.13, new environment variables should use underscores:
I don't think we have a policy for
-Xoptions, and we have a mix (I think newer ones tend to use underscores?), but I recommend using an underscore here too for the same accessibility and readability reasons as env vars. Plus consistency with the env var.For example, we added
PYTHON_CPU_COUNTand-X cpu_countin 3.13.cc@pablogsal
📚 Documentation preview 📚:https://cpython-previews--118693.org.readthedocs.build/