Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-118689: fix ePub build#118690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
methane merged 2 commits intopython:mainfrommethane:fix-epub
May 10, 2024
Merged

gh-118689: fix ePub build#118690

methane merged 2 commits intopython:mainfrommethane:fix-epub
May 10, 2024

Conversation

methane
Copy link
Member

@methanemethane commentedMay 7, 2024•
edited by github-actionsbot
Loading

m-aciek reacted with thumbs up emoji
@methane
Copy link
MemberAuthor

methane commentedMay 7, 2024•
edited
Loading

glossary.json caused unknown mimetype error. I don't know when this error starts. Maybe, recent Sphinx become more strict?

#116966 introduced JavaScript in ePub. This should be backported into 3.12.

#109438 introduced duplicated ToC error. This is Python 3.13 only issue.

@methane
Copy link
MemberAuthor

With this fix, I can open the epub file with Books.app in macOS.

There are many other errors reported by epubcheck.
Some of them are caused by opengraph.
sphinx-doc/sphinxext-opengraph#120

@methanemethane added type-bugAn unexpected behavior, bug, or error docsDocumentation in the Doc dir 3.12only security fixes needs backport to 3.12only security fixes labelsMay 7, 2024
@methane
Copy link
MemberAuthor

Another issue:
readthedocs/sphinx-notfound-page#230

@methane
Copy link
MemberAuthor

Remaining errors:

$ epubcheck --locale en-US build/epub/Python.epub 2>python-epub-errors.txt

https://gist.github.com/methane/03a569934bec14a2b4b2a783f96d01b3

@methane
Copy link
MemberAuthor

I found epub_use_index option so I use it to disable index.
Index page has been broken from start. When I show index page in Books.app, the app show only erro and I can not use the book.
Since index pages are very inaccessible (no link from toc), no one care it.

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for the fixes.

With this fix, I can open the epub file with Books.app in macOS.

Same here 👍

There are many other errors reported by epubcheck.

This sounds like something we should aim to add to the CI, even if we start with a subset of passing checks.

Thanks also for opening issues in the extensions.

humitos reacted with thumbs up emojihumitos reacted with hooray emoji
@serhiy-storchakaserhiy-storchaka added the needs backport to 3.13bugs and security fixes labelMay 9, 2024
@methanemethane merged commit7ac933e intopython:mainMay 10, 2024
@methanemethane deleted the fix-epub branchMay 10, 2024 10:24
@miss-islington-app
Copy link

Thanks@methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 10, 2024
(cherry picked from commit7ac933e)Co-authored-by: Inada Naoki <songofacandy@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 10, 2024
(cherry picked from commit7ac933e)Co-authored-by: Inada Naoki <songofacandy@gmail.com>
@bedevere-app
Copy link

GH-118889 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMay 10, 2024
@bedevere-app
Copy link

GH-118890 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelMay 10, 2024
methane added a commit that referenced this pull requestMay 10, 2024
(cherry picked from commit7ac933e)Co-authored-by: Inada Naoki <songofacandy@gmail.com>
methane added a commit that referenced this pull requestMay 10, 2024
(cherry picked from commit7ac933e)Co-authored-by: Inada Naoki <songofacandy@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

Assignees
No one assigned
Labels
3.12only security fixesdocsDocumentation in the Doc dirskip newstype-bugAn unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@methane@hugovk@serhiy-storchaka
[8]ページ先頭
©2009-2025 Movatter.jp