Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-115119: Default to --with-system-libmpdec=yes#118539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
erlend-aasland merged 14 commits intopython:mainfromerlend-aasland:libmpdec-default-to-system-libMay 6, 2024
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
14 commits Select commitHold shift + click to select a range
268d270 gh-115119: Default to --with-system-libmpdec=yes
erlend-aasland45173e3 Pull in main
erlend-aasland6f020d0 Use the same style as the surrounding code
erlend-aaslandfe56023 Fail if --with-system-libmpdec is given but no library was found
erlend-aasland0006897 Address review: warn if bundled version is used
erlend-aasland4f87c91 Address review: warn if system library was not found
erlend-aaslandf8f4ea2 For now, build with bundled libmpdec in Ubuntu CIs
erlend-aasland8e80866 Add NEWS
erlend-aaslande51c1f7 What's New
erlend-aaslanda971a26 Actually use bundled version if told to do so
erlend-aaslande3f3e17 Address review: add deprecated-removed directive regarding the remova…
erlend-aaslandc84f2b7 Add libmpdec-dev to CI deps, remove CI hack, and enforce mpdecimal ve…
erlend-aasland161d50b Pull in main
erlend-aasland1016f0d Make the mpdec link check more accurate, and use LIBS iso. LDFLAGS
erlend-aaslandFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
For now, build with bundled libmpdec in Ubuntu CIs
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitf8f4ea2327c657559cb20e7437f0116270d3b24d
There are no files selected for viewing
11 changes: 7 additions & 4 deletions.github/workflows/build.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -232,7 +232,8 @@ jobs: | ||
| ../cpython-ro-srcdir/configure \ | ||
| --config-cache \ | ||
| --with-pydebug \ | ||
| --with-openssl=$OPENSSL_DIR \ | ||
| --with-system-libmpdec=no | ||
erlend-aasland marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| build_ubuntu_free_threading: | ||
| name: 'Ubuntu (free-threading)' | ||
| @@ -246,7 +247,8 @@ jobs: | ||
| --config-cache \ | ||
| --with-pydebug \ | ||
| --with-openssl=$OPENSSL_DIR \ | ||
| --disable-gil \ | ||
| --with-system-libmpdec=no | ||
| build_ubuntu_ssltests: | ||
| name: 'Ubuntu SSL tests with OpenSSL' | ||
| @@ -371,7 +373,8 @@ jobs: | ||
| ../cpython-ro-srcdir/configure \ | ||
| --config-cache \ | ||
| --with-pydebug \ | ||
| --with-openssl=$OPENSSL_DIR \ | ||
| --with-system-libmpdec=no | ||
| - name: Build CPython out-of-tree | ||
| working-directory: ${{ env.CPYTHON_BUILDDIR }} | ||
| run: make -j4 | ||
| @@ -477,7 +480,7 @@ jobs: | ||
| save: ${{ github.event_name == 'push' }} | ||
| max-size: "200M" | ||
| - name: Configure CPython | ||
| run: ./configure --config-cache --with-address-sanitizer --without-pymalloc --with-system-libmpdec=no | ||
| - name: Build CPython | ||
| run: make -j4 | ||
| - name: Display build info | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.