Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-115775: Use__static_attributes__ to initialize shared keys#118468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

markshannon
Copy link
Member

@markshannonmarkshannon commentedMay 1, 2024
edited by bedevere-appbot
Loading

@markshannon
Copy link
MemberAuthor

No need for news item as it is covered by#117909

@markshannonmarkshannonforce-pushed theuse-attributes-to-guide-inline-values-size branch fromdedffa7 to5032ad9CompareMay 1, 2024 13:56
@markshannonmarkshannon marked this pull request as ready for reviewMay 1, 2024 20:38
@markshannonmarkshannonforce-pushed theuse-attributes-to-guide-inline-values-size branch from846a7ef toa7b858bCompareMay 2, 2024 10:47
@markshannonmarkshannonforce-pushed theuse-attributes-to-guide-inline-values-size branch fromb64de3d tod54afafCompareMay 3, 2024 18:30
@markshannon
Copy link
MemberAuthor

markshannon commentedMay 3, 2024
edited
Loading

The stats are not obviously better.

This PR reduces misses inLOAD_ATTR specializations, but it also increases the number of deferred operations due to shadowing.

BothSTORE_ATTR_WITH_HINT andLOAD_ATTR_WITH_HINT are reduced in number considerably, being replaced bySTORE_ATTR_INSTANCE_VALUE andLOAD_ATTR_INSTANCE_VALUE.

From this, it appears that this PR does what it aims to do. It also appears that it would be worth improving our handling of shadowed attributes.

I plan to fix the shadowing issue before merging this, so that it becomes a clear improvement

@markshannon
Copy link
MemberAuthor

markshannon commentedAug 23, 2024
edited
Loading

Now that#123040 is fixed things look much better.

Performance shows no change apart from the "go" benchmark speeds up by 35%. The "go" benchmark creates many objects before initializing them, which is a pattern that this PR allows us to optimize.

The stats show a small increase in specialization ofLOAD_ATTR with a 95% reduction of "not in dict" specialization failure. Almost certainly most of that is from the "go" benchmark.

@markshannonmarkshannon merged commit89328f7 intopython:mainAug 27, 2024
35 checks passed
@markshannonmarkshannon deleted the use-attributes-to-guide-inline-values-size branchAugust 27, 2024 09:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@carljmcarljmcarljm approved these changes

@methanemethanemethane approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@markshannon@carljm@methane

[8]ページ先頭

©2009-2025 Movatter.jp