Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
GH-115775: Use__static_attributes__
to initialize shared keys#118468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
GH-115775: Use__static_attributes__
to initialize shared keys#118468
Uh oh!
There was an error while loading.Please reload this page.
Conversation
No need for news item as it is covered by#117909 |
dedffa7
to5032ad9
Compare846a7ef
toa7b858b
CompareUh oh!
There was an error while loading.Please reload this page.
b64de3d
tod54afaf
Comparemarkshannon commentedMay 3, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The stats are not obviously better. This PR reduces misses in Both From this, it appears that this PR does what it aims to do. It also appears that it would be worth improving our handling of shadowed attributes. I plan to fix the shadowing issue before merging this, so that it becomes a clear improvement |
markshannon commentedAug 23, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Now that#123040 is fixed things look much better. Performance shows no change apart from the "go" benchmark speeds up by 35%. The "go" benchmark creates many objects before initializing them, which is a pattern that this PR allows us to optimize. The stats show a small increase in specialization of |
89328f7
intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.