Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-101100: Fix Sphinx warnings inlibrary/faulthandler.rst#118353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedApr 27, 2024•
edited by github-actionsbot
Loading

Fix 13 warnings:

library/faulthandler.rst:11: WARNING: py:const reference target not found: SIGSEGVlibrary/faulthandler.rst:11: WARNING: py:const reference target not found: SIGFPElibrary/faulthandler.rst:11: WARNING: py:const reference target not found: SIGABRTlibrary/faulthandler.rst:11: WARNING: py:const reference target not found: SIGBUSlibrary/faulthandler.rst:11: WARNING: py:const reference target not found: SIGILLlibrary/faulthandler.rst:18: WARNING: c:func reference target not found: sigaltstacklibrary/faulthandler.rst:73: WARNING: py:const reference target not found: SIGSEGVlibrary/faulthandler.rst:73: WARNING: py:const reference target not found: SIGFPElibrary/faulthandler.rst:73: WARNING: py:const reference target not found: SIGABRTlibrary/faulthandler.rst:73: WARNING: py:const reference target not found: SIGBUSlibrary/faulthandler.rst:73: WARNING: py:const reference target not found: SIGILLlibrary/faulthandler.rst:107: WARNING: c:func reference target not found: _exitlibrary/faulthandler.rst:107: WARNING: c:func reference target not found: _exit

Link theSIG*py:consts to thesignal module, and add! to thec:funcs which I don't think need documenting.

📚 Documentation preview 📚:https://cpython-previews--118353.org.readthedocs.build/

@AlexWaygood
Copy link
Member

PR title is interesting 👀

@hugovkhugovk changed the titlegh-101100: Add GitHub Action to ensure code changes include testsgh-101100: Fix Sphinx warnings in library/faulthandler.rstApr 27, 2024
@hugovk
Copy link
MemberAuthor

hugovk commentedApr 27, 2024•
edited
Loading

Haha, it was a mistake, corrected now!

I had some extra stuff onmain, was playing around withhttps://github.com/brettcannon/check-for-changed-files/ to trypython/core-workflow#480 (didn't get it working...). Rebased my branch before creating the PR but it kept the old default title :)

AlexWaygood reacted with heart emoji

@hugovkhugovk changed the titlegh-101100: Fix Sphinx warnings in library/faulthandler.rstgh-101100: Fix Sphinx warnings inlibrary/faulthandler.rstApr 27, 2024
Comment on lines +111 to +112
:c:func:`!_exit` with status=1 after dumping the tracebacks. (Note
:c:func:`!_exit` exits the process immediately, which means it doesn't do any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is this the same ashttps://docs.python.org/3/library/os.html#os._exit? Should this link to that, maybe?

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think so, it's calling the C one fromunistd.h:

# include<unistd.h>// _exit()

if (thread.exit)
_exit(1);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I thinkos._exit is just a very thin wrapper around the C one:

staticPyObject*
os__exit_impl(PyObject*module,intstatus)
/*[clinic end generated code: output=116e52d9c2260d54 input=5e6d57556b0c4a62]*/
{
_exit(status);
returnNULL;/* Make gcc -Wall happy */
}

But yes, good point, they're not exactly the same!

hugovk reacted with thumbs up emoji
@hugovkhugovk merged commit33c6cf3 intopython:mainApr 28, 2024
36 checks passed
@hugovkhugovk deleted the docs-fix-sphinx-warnings-faulthandler branchApril 28, 2024 18:06
@miss-islington-app
Copy link

Thanks@hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 28, 2024
…ythonGH-118353)(cherry picked from commit33c6cf3)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

GH-118366 is a backport of this pull request to the3.12 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.12only security fixes labelApr 28, 2024
hugovk added a commit that referenced this pull requestApr 28, 2024
…H-118353) (#118366)Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@hugovk@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp