Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-117225: Move colorize functionality to own internal module#118283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
5 commits Select commitHold shift + click to select a range
5a92ed9
Move colorize functionality to own internal module
hugovka0bf815
Add _colorize.get_colors and refactor
hugovk005e44e
Precompute stubbed ANSIColors with no colours
hugovkd5b06b3
Merge branch 'main' into doctest-refactor-colorize
hugovkd653c12
Merge branch 'main' into doctest-refactor-colorize
hugovkFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Precompute stubbed ANSIColors with no colours
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit005e44e2da86dd0dc3334f8f731961cfc248609b
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -17,18 +17,18 @@ class ANSIColors: | ||
YELLOW = "\x1b[33m" | ||
NoColors = ANSIColors() | ||
for attr in dir(NoColors): | ||
if not attr.startswith("__"): | ||
setattr(NoColors, attr, "") | ||
def get_colors(colorize: bool = False) -> ANSIColors: | ||
if colorize or can_colorize(): | ||
return ANSIColors() | ||
else: | ||
hugovk marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
return NoColors | ||
def can_colorize() -> bool: | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.