NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-118216: Don't consider dotted`future` imports#118267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JelleZijlstra merged 7 commits intopython:mainfromthatbirdguythatuknownot:patch-33

May 2, 2024

Merged

gh-118216: Don't consider dotted`future` imports#118267

JelleZijlstra merged 7 commits intopython:mainfromthatbirdguythatuknownot:patch-33

May 2, 2024

Conversation

Copy link

Contributor

thatbirdguythatuknownot commentedApr 25, 2024•
edited by bedevere-appbot
Loading

Add checking for the number of dots before the module name alongside__future__ name checks inPython/future.c andPython/compile.c. Basically makes a__future__ import only be considered one when no dots are present before the module name.

Issue:__future__ imports allow dots before them #118216

thatbirdguythatuknownot requested review frommarkshannon andiritkatriel ascode owners

April 25, 2024 06:17

bedevere-appbot mentioned this pull request

Apr 25, 2024

__future__ imports allow dots before them#118216

Closed

bedevere-appbot added the awaiting review label

Apr 25, 2024

thatbirdguythatuknownot force-pushed thepatch-33 branch fromf0caedc to9adb811Compare

April 25, 2024 07:00

Copy link

Contributor

nineteendo commentedApr 25, 2024

Could you also configure pre-commit?https://devguide.python.org/getting-started/setup-building/#install-pre-commit

Misc/NEWS.d/next/Core and Builtins/2024-04-25-11-48-28.gh-issue-118216.SVg700.rst:1: default role used (hint: for inline literals, use double backticks) (default-role)

thatbirdguythatuknownot force-pushed thepatch-33 branch from6f7bc77 tobb766c7Compare

April 26, 2024 00:28

JelleZijlstra reviewed

May 2, 2024

View reviewed changes

Copy link

Member

JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, this looks good. Could you add an entry to the What's New for 3.13? This is arguably a change to the language semantics.

JelleZijlstra self-assigned this

May 2, 2024

Copy link

ContributorAuthor

thatbirdguythatuknownot commentedMay 2, 2024•
edited
Loading

Got it.

thatbirdguythatuknownotand others added6 commits

May 2, 2024 14:05

Add dotted import check infuture.c

cfa0f3e

Add dotted import check incompile.c

042554a

Add tests for dotted imports of__future__

536881e

Fix dotted import tests

46c8290

📜🤖 Added by blurb_it.

62d8487

Fix Markdown

9b908ee

thatbirdguythatuknownot force-pushed thepatch-33 branch frombb766c7 to9b908eeCompare

May 2, 2024 06:05

Add entry to What's New in 3.13

019ef6f

JelleZijlstra approved these changes

May 2, 2024

View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting review labels

May 2, 2024

Copy link

Member

JelleZijlstra commentedMay 2, 2024

@thatbirdguythatuknownot thanks! One piece of feedback: please avoid force-pushing to a PR branch, as it makes review somewhat harder. Just push a new commit and we'll squash them on merge. To update the PR branch with new commits from main, either click the "Update branch" button in GitHub or rungit merge upstream/main (or whatever your remote is called) locally.