Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-118221: Always use the default row factory in sqlite3.iterdump()#118223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Show file tree
Hide file tree
Changes from1 commit
Commits
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
NextNext commit
gh-118221: Always use the default row factory in sqlite3.iterdump()
The iterdump() implementation depends on the row factory returningresulting rows as tuples; it will fail with custom row factories likefor example a dict factory.Fixed by overriding the row factory of the cursor used by iterdump().FTR, this does not affect the row factory of the parent connection.
  • Loading branch information
@erlend-aasland
erlend-aasland committedApr 24, 2024
commit48ea298b7a4c00723fcb2a03b9f6e5ca76390cdf
1 change: 1 addition & 0 deletionsLib/sqlite3/dump.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,6 +26,7 @@ def _iterdump(connection, *, filter=None):

writeable_schema = False
cu = connection.cursor()
cu.row_factory = None # Make sure we get predictable results.
# Disable foreign key constraints, if there is any foreign key violation.
violations = cu.execute("PRAGMA foreign_key_check").fetchall()
if violations:
Expand Down
15 changes: 15 additions & 0 deletionsLib/test/test_sqlite3/test_dump.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -190,6 +190,21 @@ def __getitem__(self, index):
got = list(self.cx.iterdump())
self.assertEqual(expected, got)

def test_dump_custom_row_factory(self):
# gh-118221: iterdump should be able to cope with custom row factories
def dict_factory(cu, row):
fields = [col[0] for col in cu.description]
return {k: v for k, v in zip(fields, row)}

self.cx.row_factory = dict_factory
CREATE_TABLE = "CREATE TABLE test(t);"
expected = ["BEGIN TRANSACTION;", CREATE_TABLE, "COMMIT;"]

self.cu.execute(CREATE_TABLE)
actual = list(self.cx.iterdump())
self.assertEqual(expected, actual)
self.assertEqual(self.cx.row_factory, dict_factory)

def test_dump_virtual_tables(self):
# gh-64662
expected = [
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
Fix a bug where:func:`sqlite3.iterdump` could fail if a custom:attr:`row
factory <sqlite3.Cursor.row_factory>` was supplied. Patch by Erlend Aasland.
[8]ページ先頭
©2009-2025 Movatter.jp