Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-117486: Improve behavior for user-defined AST subclasses#118212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Now, such classes will no longer require changes in Python 3.13 in the normal case.The test suite for robotframework passes with no DeprecationWarnings under this PR.I also added a new DeprecationWarning for the case where `_field_types` existsbut is incomplete, since that seems likely to indicate a user mistake.
bedevere-bot commentedApr 24, 2024
🤖 New build scheduled with the buildbot fleet by@JelleZijlstra for commitff62a21 🤖 If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
I'm planning to merge this today so we can be in a better place for beta 1. |
e042219 intopython:main 36 checks passed
Uh oh!
There was an error while loading.Please reload this page.
SonicField pushed a commit to SonicField/cpython that referenced this pull requestMay 8, 2024
…thon#118212)Now, such classes will no longer require changes in Python 3.13 in the normal case.The test suite for robotframework passes with no DeprecationWarnings under this PR.I also added a new DeprecationWarning for the case where `_field_types` existsbut is incomplete, since that seems likely to indicate a user mistake.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Now, such classes will no longer require changes in Python 3.13 in the normal case.
The test suite for robotframework passes with no DeprecationWarnings under this PR.
I also added a new DeprecationWarning for the case where
_field_typesexistsbut is incomplete, since that seems likely to indicate a user mistake.
Closes#117486
📚 Documentation preview 📚:https://cpython-previews--118212.org.readthedocs.build/