Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-117953: Share More Machinery Code Between Builtin and Dynamic Extensions#118204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ericsnowcurrently merged 5 commits intopython:mainfromericsnowcurrently:builtins-and-extensions-shared-codeApr 29, 2024
Merged
gh-117953: Share More Machinery Code Between Builtin and Dynamic Extensions#118204
ericsnowcurrently merged 5 commits intopython:mainfromericsnowcurrently:builtins-and-extensions-shared-codeApr 29, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
32a319a to6f7a862Compare9508b74 toc897f6aCompare529a160 intopython:main 35 checks passed
Uh oh!
There was an error while loading.Please reload this page.
ericsnowcurrently added a commit that referenced this pull requestAug 13, 2024
As of 529a160 (gh-118204), building with HAVE_DYNAMIC_LOADING stopped working. This is a minimal fix just to get builds working again. There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 13, 2024
…h-122952)As of 529a160 (pythongh-118204), building with HAVE_DYNAMIC_LOADING stopped working. This is a minimal fix just to get builds working again. There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately.(cherry picked from commitee1b8ce)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
blhsing pushed a commit to blhsing/cpython that referenced this pull requestAug 22, 2024
…h-122952)As of 529a160 (pythongh-118204), building with HAVE_DYNAMIC_LOADING stopped working. This is a minimal fix just to get builds working again. There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately.
Yhg1s pushed a commit that referenced this pull requestDec 3, 2024
) (#122984)gh-122907: Fix Builds Without HAVE_DYNAMIC_LOADING Set (gh-122952)As of 529a160 (gh-118204), building with HAVE_DYNAMIC_LOADING stopped working. This is a minimal fix just to get builds working again. There are actually a number of long-standing deficiencies with HAVE_DYNAMIC_LOADING builds that need to be resolved separately.(cherry picked from commitee1b8ce)Co-authored-by: Eric Snow <ericsnowcurrently@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
I've pulled this out ofgh-118116.
This change will make some later changes simpler. It also brings more consistent behavior and lower maintenance costs.