Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-117953: Split Up _PyImport_LoadDynamicModuleWithSpec()#118203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrentlyericsnowcurrently commentedApr 23, 2024
edited
Loading

I've pulled this out of#118116.

Basically, I've turned most of_PyImport_LoadDynamicModuleWithSpec() into two new functions (_PyImport_GetModInitFunc() and_PyImport_RunModInitFunc()) and moved the rest of it out into_imp_create_dynamic_impl(). There shouldn't be any changes in behavior.

This change makes some future changes simpler. This is particularly relevant to potentially calling each module init function in the main interpreter first. Thus the critical part of the PR is the addition of_PyImport_RunModInitFunc(), which is strictly focused on running the init func and validating the result. A later PR will take it a step farther by capturing error information rather than raising exceptions.

FWIW, this change also helps readers by clarifying a bit more about what happens when an extension/builtin module is imported.

@ericsnowcurrently
Copy link
MemberAuthor

@encukou, if you have a few minutes, I'm mostly looking for a sanity check on this PR.

@encukou
Copy link
Member

This PR looks good, but see my comment here:#118193 (comment)

An indirect test of a multiphase module withm_slots=NULL triggers the//assert that's commented out here.

ericsnowcurrently reacted with thumbs up emoji

@ericsnowcurrently
Copy link
MemberAuthor

Thanks. I'll take a look at that.

Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!
+1, I think this is good to merge. Theis_singlephase thing can be sorted out later, see#117953 (comment)

@ericsnowcurrentlyericsnowcurrently merged commit44f57a9 intopython:mainApr 29, 2024
35 checks passed
@ericsnowcurrentlyericsnowcurrently deleted the split-up-_PyImport_LoadDynamicModuleWithSpec-2 branchApril 29, 2024 15:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@encukouencukouencukou approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ericsnowcurrently@encukou

[8]ページ先頭

©2009-2025 Movatter.jp