Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99631: Add custom loads and dumps support for the shelve module#118065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
picnixz merged 75 commits intopython:mainfromfurkanonder:issue-99631-2
Jul 12, 2025

Conversation

furkanonder
Copy link
Contributor

@furkanonderfurkanonder commentedApr 18, 2024•
edited by github-actionsbot
Loading

Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

BsdDbShelf still usespickle.Unpickler directly to walk the keys.

furkanonder reacted with thumbs up emoji
@bedevere-app
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@@ -160,18 +181,20 @@ Restrictions
modules. The *dict* object passed to the constructor must support those
methods. This is generally accomplished by calling one of
:func:`!bsddb.hashopen`, :func:`!bsddb.btopen` or :func:`!bsddb.rnopen`. The
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

By the way, we also need to update this sentence (frombsddb toberkeleydb).bsddb is deprecated according tohttps://www.jcea.es/programacion/pybsddb.htm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It looks like the change would be bigger: it’s a new module (although the docs are not very clear) with maybe a new API.

Updating or deprecating this should be discussed in its own ticket 🙂

furkanonder and erlend-aasland reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, I agree on it. It would be better to open a new ticket to discuss this issue.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

... or consider instead opening topic on Discourse; this may need a larger audience than what you'd get on the bug tracker.

furkanonder reacted with thumbs up emoji
@furkanonder
Copy link
ContributorAuthor

furkanonder commentedJul 29, 2024•
edited
Loading

Thank you for the changes, those are much clearer now! I don't have any other comments (by the way, thank you for being reactive and accepting my feedback!)

You're welcome. Thank you so much for your time and effort.

picnixz reacted with heart emoji

@furkanonderfurkanonder added awaiting review and removed 3.14bugs and security fixes awaiting changes labelsSep 13, 2024
Copy link
Member

@picnixzpicnixz left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some few nitpicks that I thought of. Some should be addressed (3.15 -> next + self.subTest(proto=5)`, while others are purely cosmetics.

I'll let a core dev check other stuff (

This core dev is now me.

furkanonder reacted with thumbs up emoji
@furkanonderfurkanonder requested a review frompicnixzMay 30, 2025 16:04
Copy link
Member

@picnixzpicnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Almost done!

furkanonder reacted with thumbs up emoji
@picnixzpicnixz merged commitdda70fa intopython:mainJul 12, 2025
39 checks passed
@picnixz
Copy link
Member

picnixz commentedJul 12, 2025•
edited
Loading

Oof, I forgot to merge main. Well, I don't think something for shelve changed in between and there were no conflicts, so it should be fine. Thanks for waiting!

furkanonder reacted with thumbs up emoji

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull requestJul 12, 2025
…e` module (python#118065)Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz added a commit to picnixz/cpython that referenced this pull requestJul 13, 2025
…e` module (python#118065)Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>Co-authored-by: Petr Viktorin <encukou@gmail.com>Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@furkanonder
Copy link
ContributorAuthor

Oof, I forgot to merge main. Well, I don't think something for shelve changed in between and there were no conflicts, so it should be fine. Thanks for waiting!

Thanks for the merge!

picnixz reacted with heart emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@merwokmerwokmerwok left review comments

@eendebakpteendebakpteendebakpt left review comments

@picnixzpicnixzpicnixz approved these changes

@erlend-aaslanderlend-aaslanderlend-aasland left review comments

@encukouencukouAwaiting requested review from encukou

Assignees
No one assigned
Labels
stdlibPython modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@furkanonder@picnixz@encukou@merwok@eendebakpt@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp