Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-116622: Redirect stdout and stderr to system log when embedded in an Android app#118063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 19 commits intopython:mainfrommhsmith:android-log
Apr 30, 2024

Conversation

mhsmith
Copy link
Member

@mhsmithmhsmith commentedApr 18, 2024•
edited
Loading

When embedded in an app on current versions of Android, there's no easy way to monitor the process's stdout and stderr. So, as specified inPEP 738, this PR redirects them to the system log, which can be viewed using the developer tools.

@mhsmith
Copy link
MemberAuthor

@serhiy-storchaka: This PR is connected to theio module, which I see you've been working on recently. Are you able to review it?

Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!
This looks good to me, modulo a few small nitpicks. I'll let@serhiy-storchaka resolve the conversations he started.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for addressing my comments. LGTM in general. I left several minor suggestions, but they are not mandatory, you can implement or reject them on case by case base.

In any case I'm going to merge this PR after your answer.

Copy link
Member

@encukouencukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Using the tooling and instructions in#117878, I've confirmed that this works for the test suite:

image

@erlend-aaslanderlend-aasland removed their request for reviewApril 30, 2024 07:34
mhsmithand others added2 commitsApril 30, 2024 12:54
Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinnervstinner merged commit3b268f4 intopython:mainApr 30, 2024
@vstinner
Copy link
Member

Merged. Let's see how it goes. It can be adjusted later if needed.

Nice change@mhsmith.

ericsnowcurrently reacted with hooray emoji

SonicField pushed a commit to SonicField/cpython that referenced this pull requestMay 8, 2024
SonicField pushed a commit to SonicField/cpython that referenced this pull requestMay 8, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner left review comments

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

@erlend-aaslanderlend-aaslanderlend-aasland left review comments

@encukouencukouencukou approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@mhsmith@vstinner@encukou@serhiy-storchaka@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp