Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-109118: Allow lambdas in annotation scopes in classes#118019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JelleZijlstra merged 1 commit intopython:mainfromJelleZijlstra:lambdaanno
Apr 22, 2024

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commentedApr 18, 2024
edited by github-actionsbot
Loading

Copy link
Member

@carljmcarljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks fine! I do think this will probably be the most intuitive behavior, though it's a little weird in principle for visibility to not be transitive. I guess it didn't turn out to be the case at all that this non-transitivity would require re-working abstractions insymtable.c!

I apologize in advance for the difficulties I assume you will encounter in making this work for comprehensions :/

@JelleZijlstra
Copy link
MemberAuthor

Thanks! Yes, I tried locally to do the same thing for comprehensions and couldn't get it to work yet. The naive change (just remove the code that throws a SyntaxError for comprehensions in annotation scopes) no longer crashes like it did in#109118, but due to inlining it doesn't produce the right scoping semantics. I tried to do something like what we did last year in#104528 but couldn't get it to work yet. I haven't had time yet to get back to this.

@JelleZijlstra
Copy link
MemberAuthor

One approach I thought of was to simply not inline comprehensions in annotation scopes, but that doesn't seem right as comprehensions would now behave differently in annotation scopes versus elsewhere.

@JelleZijlstraJelleZijlstra merged commit85f727c intopython:mainApr 22, 2024
40 checks passed
@JelleZijlstraJelleZijlstra deleted the lambdaanno branchApril 22, 2024 19:50
@carljm
Copy link
Member

If you want to (at some point when you get back to it, no rush) push a non-working version with inlined comprehensions in annotation scopes, I'm also willing to take a look and see what I can figure out.

JelleZijlstra reacted with thumbs up emoji

@JelleZijlstra
Copy link
MemberAuthor

Thanks! I opened#118160 with what I have so far.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@carljmcarljmcarljm approved these changes

@larryhastingslarryhastingsAwaiting requested review from larryhastings

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@JelleZijlstra@carljm

[8]ページ先頭

©2009-2025 Movatter.jp